Fixed inconsistent appdistribution prompt (#8096)

[a-25]

Fix for issue (#8096), prompt is shown consistently.

[ryanwilson]

Thanks for the contribution @a-25. A quick question, did you look into the UISceneDidActivateNotification at all to see if it could be used instead? Seems like it could be useful and would let us avoid just looping without knowing the state.

[a-25]

@ryanwilson Hello. No, I didn't. Will look at it closely and return with changes or conclusions.

[a-25]

Hello, @ryanwilson. Implemented using UISceneDidActivateNotification. Seems to me that it is a cleaner way.

[ryanwilson]

Apologies for the delay in review, will be getting to it soon! Thanks for the update as well.

[a-25]

A couple comments to start!

Hello, @ryanwilson. Thanks for your comments, worked them out.

[a-25]

Hi, @ryanwilson. Finished with comments fixing. Perhaps, I'd better resolve all conversations so that you received a notification?

[tejasd]

Hi @a-25 - thanks for the PR!

There's a simpler fix (focused on single scenes) - does this work in your case? Or does your use case involve multiple scenes?

https://github.com/firebase/firebase-ios-sdk/pull/10288

[a-25]

Hi, @tejasd. My case was for multiple scenes, as I remember. At least, I cannot guarantee that the original bug appears only in one-scene apps.

[paulb777]

Please close, merge, or comment. We plan to close stale PRs on November 28, 2023.

[a-25]

@ryanwilson, @tejasd: what do you think, should it be merged?

[paulb777]

Looks like no immediate plans to move forward on this. I'll close and we can reopen if plans change.