firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

[Firebase Auth] - MacOS support for SigninWithProvider

Open Mooyeee opened this issue 2 months ago • 4 comments

This PR adds support for the method signInWithProvider (from the flutter SDK) for macOS, allowing us to login with SSO on macOS platform. Tried with Microsoft AD SSO. The proposed solution mimics the iOS one but implemented of course with AppKit.

Linked Issues: https://github.com/firebase/firebase-ios-sdk/issues/14990

Let me know if something looks odd :)

Mooyeee avatar Oct 20 '25 21:10 Mooyeee

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

gemini-code-assist[bot] avatar Oct 20 '25 21:10 gemini-code-assist[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 20 '25 21:10 google-cla[bot]

I've noticed some issues and fixed them :) The issues:

  • The user closing flow wasn't correctly notified to flutter, overriding close instead of performClose fixed it
  • The first frame of the NSWindow was white until a resize; I was mistakenly creating two spinners and two webviews, creating them once fixed the issue

Also formatted the code

Mooyeee avatar Oct 22 '25 21:10 Mooyeee

Any update regarding the merging of this amazing PR?

Vincz avatar Nov 17 '25 09:11 Vincz