firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

[WIP] Streamable functions

Open ncooke3 opened this issue 10 months ago • 1 comments


Contribution Workflow

  1. Fork the Firebase repo and clone it.
  2. Add Upstream: git remote add upstream https://github.com/firebase/firebase-ios-sdk.git
  3. Create Branch: git fetch upstream && git checkout -b <feature-branch> upstream/streamable-functions
    • Where <feature-branch> is the name of the branch (e.g., add-tests-streamable).
  4. Regular workflow: Run style script and git add . && git commit -m "..."
  5. Push: git push origin <feature-branch>
  6. PR: Create a PR on GitHub, with base branch set tofirebase:streamable-functions
  7. Update fork feature branch (if needed):
git fetch upstream
git checkout <feature-branch>
git merge upstream/streamable-functions
git push origin <feature-branch>

ncooke3 avatar Jan 29 '25 15:01 ncooke3

Apple API Diff Report

Commit: 80622d6835b463cdcf7045bb7dbbd22c481fbd40 Last updated: Wed Feb 26 08:04 PST 2025 View workflow logs & download artifacts


FirebaseFunctions

Enumerations

[ADDED] StreamResponse
[ADDED] StreamResponse
Swift:
+  public enum StreamResponse < Message : Decodable , Result : Decodable > : Decodable , StreamResponseProtocol
+    case message ( Message )
+    case result ( Result )
+    public init ( from decoder : any Decoder ) throws

Structures

Callable
[ADDED] stream(_:)
Swift:
+  func stream ( _ data : Request ? = nil ) throws -> AsyncThrowingStream < Response , Error >

github-actions[bot] avatar Jan 29 '25 15:01 github-actions[bot]

/gemini please review

ncooke3 avatar Mar 06 '25 19:03 ncooke3

Okay, I will review the pull request now.

gemini-code-assist[bot] avatar Mar 06 '25 19:03 gemini-code-assist[bot]

/gemini Still reviewing?

ncooke3 avatar Mar 06 '25 23:03 ncooke3

It appears I am still reviewing the pull request. I will provide feedback as soon as possible.

gemini-code-assist[bot] avatar Mar 06 '25 23:03 gemini-code-assist[bot]

This should be in a good state. I'll address any further comments in a follow-up PR.

ncooke3 avatar Mar 10 '25 18:03 ncooke3