firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Streamable HTTPCallabe functions

Open eBlender opened this issue 11 months ago • 4 comments

Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

eBlender avatar Dec 27 '24 21:12 eBlender

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 27 '24 21:12 google-cla[bot]

@paulb777 Thanks Paul, Done.

eBlender avatar Jan 06 '25 22:01 eBlender

For the check CI failure, use the scripts/style.sh script.

You can use it a few ways, but I like to either pass it a list of files:

scripts/style.sh FirebaseFunctions/Tests/Unit/FunctionsTests.swift

Or periodically style all of the files I touched in my branch:

git diff --name-only main | xargs scripts/style.sh

Then git add and commit the result.

If the script fails, it's likely due to missing packages, you'll need:

brew install clang-format@19
brew install mint

ncooke3 avatar Jan 16 '25 00:01 ncooke3

@paulb777 and @ncooke3 Thanks for your comments and help.

eBlender avatar Jan 16 '25 01:01 eBlender

Hi @eBlender, I did some investigating and put together https://github.com/firebase/firebase-ios-sdk/pull/14376/commits/3e325aaa2c5624f85fea861bf220d6de6cae4615. Instead of pushing to your fork, I copied this PR's commits into a branch of the repo and opened a PR, #14376. Do you think you could work off that by forking off the #14376's branch? LMK if you are further ahead, as #14376 is a barebones impl. with more work needed to refine it.

ncooke3 avatar Jan 23 '25 03:01 ncooke3

Closing in favor of: #14395

ncooke3 avatar Jan 29 '25 15:01 ncooke3

Hi @eBlender, I did some investigating and put together 3e325aa. Instead of pushing to your fork, I copied this PR's commits into a branch of the repo and opened a PR, #14376. Do you think you could work off that by forking off the #14376's branch? LMK if you are further ahead, as #14376 is a barebones impl. with more work needed to refine it.

Of course @ncooke3 will continue in 14395 👍

eBlender avatar Jan 29 '25 21:01 eBlender