firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

[Auth] Add support for upcoming Recaptcha changes

Open ncooke3 opened this issue 1 year ago • 3 comments

Corresponding PR for https://github.com/google/interop-ios-for-google-sdks/pull/16 ~that is backwards compatible for Recaptcha ≤18.6~ (edit: backwards compatible is not needed due to dependency versioning)

Support Cases

  1. Old Recaptcha x Old Firebase → ✅ Will continue to work, no changes
  2. Old Recaptcha x New Firebase → ❌ Won't work because of conflicting recaptcha interop dependency
  3. New Recaptcha x Old Firebase → ❌ Won't work because of conflicting recaptcha interop dependency
  4. New Recaptcha x New Firebase → ✅ Will work bc of this PR

Testing (manual tests– is reCaptcha token generated?)

  • [x] CocoaPods - dynamic linking
  • [x] CocoaPods - static linking
  • [x] SPM manual test
  • [ ] Zip manual test (will wait for new Recaptcha interop and Recaptcha SDK to be released)

TODOs

  • [ ] Looking into the existing rCE unit test PRs to see if we can get unit tests checked in too

cc: @walterjgsp

ncooke3 avatar Dec 02 '24 23:12 ncooke3

Adding this to M158 milestone for consideration. Will probably slip to M159.

ncooke3 avatar Dec 06 '24 20:12 ncooke3

Moved back to a later milestone as new Recaptcha version is not yet released.

ncooke3 avatar Jan 07 '25 21:01 ncooke3

Moved back to a later milestone as new Recaptcha version is not yet released.

ncooke3 avatar Jan 28 '25 15:01 ncooke3