firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Fix Performance Unit Tests requiring Unswizzling

Open samedson opened this issue 1 year ago • 3 comments

There are tests that supposedly require unswizzling, but when I remove the assertion, they all pass. There doesn't seem to be any issues removing all unswizzling from the unit tests.

#no-changelog

samedson avatar Oct 03 '24 15:10 samedson

Screenshot 2024-10-03 at 11 26 10 AM

Just one test failure

samedson avatar Oct 03 '24 15:10 samedson

https://github.com/firebase/firebase-ios-sdk/issues/11903

samedson avatar Oct 03 '24 15:10 samedson

I'm not comfortable with this PR. Without unswizzling, the tests will not be accurate. The host app would not be reset across every test. So, if one test does swizzling and if it fails to unswizzle - then the rest of the tests would run on a swizzled app which might not build confidence on the rest of the tests. So, we should not remove the unswizzling capability from tests.

visumickey avatar Dec 19 '24 19:12 visumickey