firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Initial config v2 support (partial)

Open paulb777 opened this issue 1 year ago • 3 comments

Initial updates to support config v2.

To keep the changes smaller, keeping the FIROptions dictionary backing store, but that should probably go away.

The PR is still incomplete and only useful to see the direction it's headed.

paulb777 avatar Sep 05 '24 00:09 paulb777

1 Warning
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot avatar Sep 05 '24 00:09 google-oss-bot

Apple API Diff Report

Commit: 6d569dd41babd6d3be8dc6e83025f57dd9dacf5b Last updated: Fri Sep 13 06:51 PDT 2024 View workflow logs & download artifacts


FirebaseCore

Classes

FIROptions
[MODIFIED] -initWithContentsOfFile:
Swift:
+  init ?( contentsOfFile configPath : String )
-  init ?( contentsOfFile plistPath : String )
Objective-C:
+  - ( nullable instancetype ) initWithContentsOfFile :( nonnull NSString * ) configPath ;
-  - ( nullable instancetype ) initWithContentsOfFile :( nonnull NSString * ) plistPath ;
[ADDED] -initWithAppID:projectNumber:projectID:apiKey:
Swift:
+  init ( appID : String , projectNumber : String , projectID : String , apiKey : String )
Objective-C:
+  - ( nonnull instancetype ) initWithAppID :( nonnull NSString * ) appID projectNumber :( nonnull NSString * ) projectNumber projectID :( nonnull NSString * ) projectID apiKey :( nonnull NSString * ) apiKey ;
[ADDED] projectNumber
Swift:
+  var projectNumber : String { get set }
Objective-C:
+  @property ( nonatomic , copy ) NSString * _Nonnull projectNumber ;

github-actions[bot] avatar Sep 05 '24 00:09 github-actions[bot]

FYI, addressed a merge conflict introduced by my #13627

ncooke3 avatar Sep 13 '24 13:09 ncooke3