firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Adding Integration Test for Phone Number Authentication in Firebase

Open srushtisv opened this issue 1 year ago • 5 comments

Implement integration test for verifying phone number sign-in with Firebase Auth. Please review and approve.

srushtisv avatar Aug 23 '24 21:08 srushtisv

1 Warning
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot avatar Aug 23 '24 21:08 google-oss-bot

LLC is missing. See other files in the repo or https://github.com/firebase/firebase-ios-sdk/blob/main/scripts/check_copyright.sh#L21

paulb777 avatar Aug 23 '24 22:08 paulb777

Thanks for working on tests. The new file should be added to the SwiftApiTests target in the Xcode project so it builds and runs.

When I do that locally, it has some failures.

Also, it would be great to test the async variations of the APIs as well.

confirmed they are building and running:

PhoneAuthTests
    ✓ testSignInWithPhoneNumber (0.997 seconds)
    ✓ testSignInWithPhoneNumberAsync_Success (1.066 seconds)

from https://github.com/firebase/firebase-ios-sdk/actions/runs/10625088625/job/29454486166?pr=13538#step:6:340

ncooke3 avatar Aug 30 '24 19:08 ncooke3

Thanks for working on tests. The new file should be added to the SwiftApiTests target in the Xcode project so it builds and runs.

When I do that locally, it has some failures.

Also, it would be great to test the async variations of the APIs as well.

done

srushtisv avatar Aug 30 '24 19:08 srushtisv

@srushtisv Any reason this code hasn't yet merged to main? Ideally, we should merge larger PRs to main as soon as possible to avoid unnecessary branching.

paulb777 avatar Sep 16 '24 22:09 paulb777