firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

[FR]: Avoid if it's possible hardcoded strings to reduce framework size

Open jesus-mg-ios opened this issue 7 months ago • 6 comments

Description

I'm wondering if is possible reduce the comments in asserts and string hardcoded that could have no impact in clients sdks, because they are for development purposes. Doing this the binary size could be reduced.

As examples, of what a binary nowadays contains because it uses firebase. https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/core/src/remote/exponential_backoff.cc#L68 https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/core/src/util/filesystem_win.cc#L137 https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/Source/API/FSTUserDataReader.mm#L296 https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/Source/API/FSTUserDataReader.mm#L584 https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/core/src/util/random_access_queue.h#L111

API Proposal

No response

Firebase Product(s)

AB Testing, Analytics, App Check, App Distribution, Authentication, Crashlytics, Database, DynamicLinks, Firestore, Functions, In-App Messaging, Installations, ML Model Downloader, Messaging, Performance, Remote Config, Storage, Vertex AI

jesus-mg-ios avatar Jul 16 '24 22:07 jesus-mg-ios