firebase-ios-sdk
firebase-ios-sdk copied to clipboard
[auth-swift] Fix two flow porting errors in AuthURLPresenter.swift
While doing exploratory testing investigating the GitHub provider workflow for #11759, I discovered that dismissing the sign in window didn't properly reset to try again and then once fixing that, the dismiss didn't happen in the main thread.
Fixed by implementing the missed SFSafariViewControllerDelegate delegate method - safariViewControllerDidFinish and fixing the async queue for the dismiss method.
| 1 Warning | |
|---|---|
| :warning: | Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.) |
Generated by :no_entry_sign: Danger