[FR]: Add privacy manifest to GoogleAppMeasurementOnDeviceConversion

[ben-p-commits]

Description

It appears that GoogleAppMeasurementOnDeviceConversion was missed when privacy manifests were added to the various modules in this repository.

I see usage of lstat and stat in the binary that will require this be handled for applications using this dependency.

Note: I used this tool to spot this issue: https://github.com/Wooder/ios_17_required_reason_api_scanner

API Proposal

No response

Firebase Product(s)

Analytics

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[ncooke3]

Hi @ben-p-commits, what version of GoogleAppMeasurementOnDeviceConversion are you using?

cc: @tsunghung

[ben-p-commits]

.product(name: "FirebaseAnalyticsOnDeviceConversion", package: "firebase-ios-sdk"), from: .package(url: "https://github.com/firebase/firebase-ios-sdk", exact: "10.22.1"),

[tsunghung]

Thanks for reporting this. We have noticed this as well and will remove the unnecessary dependencies in the next release.

[ben-p-commits]

Thanks for the quick reply!

I suppose the plan makes this more of a bug report rather than an FR 🤣

[ncooke3]

10.24.0 is now available and features the removal of lstat and stat from the GoogleAppMeasurementOnDeviceConversion binary.

[ben-p-commits]

@ncooke3, thanks so much for the quick turnaround!

Small nitpick in case it was missed: the 10.24 changelog doesn't seem to mention this for 10.24.0.

[ncooke3]

Hi @ben-p-commits, no problem! For the release note, GoogleAppMeasurementOnDeviceConversion is part of Google Analytics for Firebase, so this required reasons cleanup was tied to "Internal code cleanup." from https://firebase.google.com/support/release-notes/ios#analytics