firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

An attempt at fixing #12168 by only returning the cached data at the child path rather than at the parent

Open mortenbekditlevsen opened this issue 7 months ago • 3 comments

Discussion

This attempts to fix the issue reported here:

https://github.com/firebase/firebase-ios-sdk/issues/12168

Testing

I will be adding tests to this PR.

API Changes

mortenbekditlevsen avatar Dec 05 '23 11:12 mortenbekditlevsen

I forgot how to run tests when using SPM, so I haven't had any luck with the testing yet.

mortenbekditlevsen avatar Dec 05 '23 11:12 mortenbekditlevsen

Thanks @mortenbekditlevsen! It looks like the tests pass on CI other than needing clang-format.

@maneesht Would you take a look?

paulb777 avatar Dec 05 '23 14:12 paulb777

cc: @aashishpatil-g

paulb777 avatar Dec 05 '23 14:12 paulb777