firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

add `setNumberOfStackFramesToSkipForNotFatalErrors`

Open paulz opened this issue 1 year ago • 8 comments

Proposal for https://github.com/firebase/firebase-ios-sdk/issues/11475

API Changes

  • This is a proposal to add a method to set number of stack trace frames to be skipped for non-fatal errors.

Similar to Bugsnag: https://docs.bugsnag.com/platforms/ios/customizing-error-reports/#modifying-stack-traces

paulz avatar Jun 26 '23 08:06 paulz

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 26 '23 08:06 google-cla[bot]

Thanks for the PR and sorry about the delayed response. Please sign the CLA

paulb777 avatar Jul 06 '23 00:07 paulb777

Thanks for the PR and sorry about the delayed response. Please sign the CLA

Done ✅

paulz avatar Jul 07 '23 05:07 paulz

Thanks! Looks like CI is showing some test failures.

paulb777 avatar Jul 07 '23 13:07 paulb777

Thanks! Looks like CI is showing some test failures.

I've added unit test, hope CI will pass now.

paulz avatar Jul 09 '23 11:07 paulz

@paulb777 @samedson is there any chance to merge this?

paulz avatar Sep 02 '23 01:09 paulz

Hi @paulz, I'll sync with Sam about this PR this week. Since it's changing the public API surface, there's an internal API review process it'll need to go through before merging. I'll keep you in the loop– thanks again for the contribution.

ncooke3 avatar Sep 04 '23 15:09 ncooke3

Hi @ncooke3 @samedson, is there any way to move forward regarding this PR ? This would be a nice improvement in our declaration of non-fatal errors.

arnaudlbbnc avatar Jul 13 '24 13:07 arnaudlbbnc