firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

[FR]: [Crashlytics] Add flag to skip stack trace capture for errors

Open anton-plebanovich opened this issue 1 year ago • 14 comments

Description

I don't need stack trace for my errors and so I want to reduce performance impact by skipping stack trace capture at all. I log errors in the background thread in the special logger class and so the stack trace is always the same for all errors. Moreover, since it impacts the error title on the Crashlytics report page it looks messy. image

If possible, I want to also control the error title. At least I want to return it to the previous times when it was set from the error domain.

API Proposal

Not sure if it impacts API somehow. If stack trace is a required parameter it may require some changes to properly process it when it is a nil value.

Firebase Product(s)

Crashlytics

anton-plebanovich avatar Jun 18 '23 09:06 anton-plebanovich

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar Jun 18 '23 09:06 google-oss-bot

we have a similar issue: https://github.com/firebase/firebase-ios-sdk/issues/11474

we have many errors with the same title, but would like to keep stack traces, just trimmed to the actual error

paulz avatar Jun 26 '23 08:06 paulz

Hi @anton-plebanovich, it seems that your issue is caused by the recent changes on how Crashlytics groups the issues. I've found a similar request internally, but we can't share any details or timeline as to when this could be materialized. I'll keep this issue open and we will let you know of any updates regarding this. Thanks!

rizafran avatar Jun 27 '23 12:06 rizafran

Thanks @rizafran for the reply 👍

anton-plebanovich avatar Jun 27 '23 13:06 anton-plebanovich

Is there any update? The infomation at crashlytics is hardly readable. We got more than 100 events in one variant, all I can do is clicking the left right arrow to check every single event, that is realy annoying.

image

wardehuang avatar Jan 02 '24 03:01 wardehuang

In my case, the issue was solved Firebase/Crashlytics (10.19.0)

anton-plebanovich avatar Jan 02 '24 07:01 anton-plebanovich

In my case, the issue was solved Firebase/Crashlytics (10.19.0)

I am using bom, I will try to specify that version manually, thanks. image

wardehuang avatar Jan 02 '24 07:01 wardehuang

And I'm on the iOS platform, so I am not sure about the Android

anton-plebanovich avatar Jan 02 '24 07:01 anton-plebanovich

I've just check that I was using the latest version (18.6.0) of Crashlytics Android. The problem is still exists :(

wardehuang avatar Jan 02 '24 08:01 wardehuang

Since the issue is solved on iOS, I'll close. For Android, please follow or open an issue at https://github.com/firebase/firebase-android-sdk/issues

paulb777 avatar Jan 02 '24 14:01 paulb777

Hi @paulb777 Even though the issue is resolved, initially it was a request about adding a flag to be able to remove stack trace info from Crashlytics error reports. That's why it is labeled [FR] (feature request). I don't know if that's already possible in the latest release but it does not look so

anton-plebanovich avatar Jan 02 '24 15:01 anton-plebanovich

Thanks for the clarification. I'll leave it open for the Crashlytics team to assess.

paulb777 avatar Jan 02 '24 15:01 paulb777

@anton-plebanovich thanks for the request. We don't have plans to exclude stack traces from reports since that logging use case falls outside of Crashlytics. If you're mainly looking to log the number of event occurrences, using Google Analytic Events is maybe a better option. I am interested in looking at improvements we can make to the issue titles. Are you able to send me your Firebase project ID to [email protected]?

alexsinger avatar Jan 02 '24 20:01 alexsinger

Hi @alexsinger there is no issue with the titles anymore. It was fixed already. There are two concerns regarding stack trace capture for error reports:

  • It slowdowns execution
  • It does not provide any useful info in my use case since I always log errors from the same place

I also checked existing logic and there is a recordExceptionModel method for FIRCrashlytics which allows the submission of a custom stack trace that might be empty so I thought it would be possible to implement a similar thing for error reports.

Is error capture so fundamentally different from exception capture that we can't have an empty stack trace there? Or, is it possible to submit a dummy/constant stack trace at least?

anton-plebanovich avatar Jan 03 '24 09:01 anton-plebanovich