firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard
verified publisher icon firebase

Add Sessions Internal API

Open samedson opened this issue 2 years ago • 2 comments

Follow on from https://github.com/firebase/firebase-ios-sdk/pull/10636 and https://github.com/firebase/firebase-ios-sdk/pull/10664

  • [x] Use non-default Notification Center

TODO

In a later PR I will add:

  • Tests
  • Testapp Fixes

samedson avatar Jan 10 '23 21:01 samedson

Size Report 1

Affected Products

  • FirebaseCrashlytics

    TypeBase (0df86ea)Merge (a3a2fb5)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

google-oss-bot avatar Jan 10 '23 21:01 google-oss-bot

2 Warnings
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)
:warning: New public headers were added, did you remember to add them to the umbrella header?

Generated by :no_entry_sign: Danger

google-oss-bot avatar Jan 10 '23 23:01 google-oss-bot

@visumickey

I'm thinking if updateSettings should be done before waiting for all the dependencies initialization. What is the rationale to wait for all the dependencies to be initialized?

We need to wait for dependencies to initialize so that we know the data collection state. Settings can't fetch data without data collection approved

samedson avatar Jan 12 '23 16:01 samedson