firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Implement token revocation public api

Open renkelvin opened this issue 1 year ago • 4 comments

Implement token revocation public api. Note that it's not e2e tested yet.

Internal API review at go/gcip-token-revocation-api

renkelvin avatar Dec 15 '22 08:12 renkelvin

1 Warning
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot avatar Dec 15 '22 15:12 google-oss-bot

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 57.14% (3f845e5) to 56.99% (49b4a3a) by -0.15%.

    FilenameBase (3f845e5)Merge (49b4a3a)Diff
    FSRWebSocket.m40.13%38.14%-2.00%

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from 70.98% (3f845e5) to 70.94% (49b4a3a) by -0.04%.

    FilenameBase (3f845e5)Merge (49b4a3a)Diff
    FIRRemoteConfig.m84.20%83.91%-0.29%

Test Logs

google-oss-bot avatar Dec 15 '22 15:12 google-oss-bot

@peterfriese Please take a look, thanks!

renkelvin avatar Jan 04 '23 18:01 renkelvin

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (9d8033d)Merge (8cc5f4b)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

google-oss-bot avatar Jan 05 '23 21:01 google-oss-bot

Due to backend limitation, we gonna revoke refresh token instead of authorization code. Please help review the PR again. Thanks!

renkelvin avatar Mar 23 '23 18:03 renkelvin

Please fix CI. You may need to rebase or merge master to do so.

Interesting, I think I got a green CI initially.. The diff messed up after rebasing. Recreated https://github.com/firebase/firebase-ios-sdk/pull/11001

renkelvin avatar Mar 23 '23 21:03 renkelvin