Address 9963 review feedback

Open paulb777 opened this issue 3 years ago • 1 comments

Use callback? instead of if let callback ...
Better StorageDownloadTask enqueue signature
Restore non-optional bucket property in StorageMetadata

Initializing an unspecified bucket property as "" instead of nil when creating StorageMetadata with a dictionary was an inadvertent Firebase 9 change from Firebase 8. This PR keeps the Firebase 9 behavior onto Firebase 10.

Sep 21 '22 19:09 paulb777

1 Warning

:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

	1 Warning
:warning:	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

Sep 21 '22 19:09 google-oss-bot