firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Update versions for Release 9.5.0

Open charlotteliang opened this issue 3 years ago • 4 comments

charlotteliang avatar Aug 09 '22 20:08 charlotteliang

1 Warning
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot avatar Aug 09 '22 20:08 google-oss-bot

Looks like an unrelated infra issue in the firestore tests - https://github.com/firebase/firebase-ios-sdk/runs/7755695980?check_suite_focus=true#step:5:42

paulb777 avatar Aug 09 '22 22:08 paulb777

Yeah, will submit if the rest is green.

charlotteliang avatar Aug 09 '22 22:08 charlotteliang

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.57% (879d0b4) to 88.57% (88e1691) by -0.00%.

    FilenameBase (879d0b4)Merge (88e1691)Diff
    task.cc94.78%93.91%-0.87%

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 63.88% (879d0b4) to 63.80% (88e1691) by -0.08%.

    FilenameBase (879d0b4)Merge (88e1691)Diff
    FIRMessagingCheckinService.m90.54%88.29%-2.25%

Test Logs

google-oss-bot avatar Aug 09 '22 23:08 google-oss-bot

I believe the failing watchOS workflow is due to #10082. It should have been surfaced by #10082 but wasn't so I have sent #10091 to fix this separate issue.

I'll look into fixing the watchOS workflow.

ncooke3 avatar Aug 10 '22 15:08 ncooke3