firebase-ios-sdk
firebase-ios-sdk copied to clipboard
firebase
RC Dynamic property wrapper feature
This feature is built on top of real time config so please just look at the RemoteConfigSwift folder for the code change by selecting FirebaseRemoteConfigSwift on the top left nav bar.
Also add a SwiftUI Sample test app to visualize the API experience.
| 1 Warning | |
|---|---|
| :warning: | Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.) |
Generated by :no_entry_sign: Danger
Size Report 1
Affected Products
FirebaseRemoteConfigType Base (26075af) Merge (be24676) Diff CocoaPods 752 kB 769 kB +16.9 kB (+2.2%)
Test Logs
- Base (26075af): https://github.com/firebase/firebase-ios-sdk/actions/runs/2783662010
- Merge (be24676): https://github.com/firebase/firebase-ios-sdk/actions/runs/2793212897
Coverage Report 1
Affected Products
FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.frameworkOverall coverage changed from 79.58% (26075af) to 72.25% (be24676) by -7.33%.
Filename Base (26075af) Merge (be24676) Diff FIRRemoteConfig.m 83.61% 83.78% +0.17% RCNConfigExperiment.m 92.25% 90.70% -1.55% RCNConfigFetch.m 79.52% 79.55% +0.03% RCNConfigRealtime.m ? 26.11% ?
Test Logs
- Base (26075af): https://github.com/firebase/firebase-ios-sdk/actions/runs/2783662010
- Merge (be24676): https://github.com/firebase/firebase-ios-sdk/actions/runs/2793212897
Please change the base branch so the PR only shows the property wrapper changes.
On idea to eliminate the force unwraps would be to have type specific property wrappers like RemoteConfigPropertyInt, RemoteConfigPropertyString, RemoteConfigPropertyArray, RemoteConfigPropertyStruct, etc.
Then they could all use guard try? ... else set default value except for RemoteConfigPropertyStruct which would need the property wrapper to take a default value parameter.