Typescript compilation error: Argument of type 'Express' is not assignable [..]

[remie]

Version info

node v10.16.0

firebase-functions: ^3.3.0

firebase-tools: 7.8.1

express ^4.17.1

Test case

import * as functions from 'firebase-functions';
import * as express from 'express';

const app = express();
export const api = functions.https.onRequest(app);

Steps to reproduce

Add the test case in an Typescript enable environment

Expected behavior

The onRequest handler should not throw Typescript compilation errors

Actual behavior

Typescript compilation error:

error TS2345: Argument of type 'Express' is not assignable to parameter of type '(req: Request, resp: Response) => void'.
  Types of parameters 'req' and 'req' are incompatible.

Were you able to successfully deploy your functions?

Yes, when I ignore typescript by casting it as <any> it deploys and runs as expected:

export const api = functions.https.onRequest(<any>app);

This is only a typing issue.

[HiddenBehindTheKeyBoard]

abra o caminho: functions>src no terminal de comando e faça um npm install --save express

[kossnocorp]

I've upgraded to firebase-functions from 3.3.0 to 3.6.0 and now also have this issue. I managed to fix it with any, but it's not ideal.

[jpinilloslr]

Same issue with firebase-functions 3.6.0.

[brendanmc6]

Likewise since updating to the latest version of firebase-functions. I was previously on 3.3.0.

[dcgudeman]

I am also experiencing the same issue after upgrading firebase-functions from 3.3.0 to 3.6.1

[Arno-Z]

I have fixed my firebase import to 3.3.0 in packages.json.

"firebase-functions": "3.3.0",

followed by a npm update solved it for now. But this is confirmed an issue with the ^3.6.0 version.

[kimroen]

Still seeing this with firebase-functions 3.7.0. Really wanting to update for the Node 10 improvements (considering all the Google libraries rapidly dropping support for Node 8 😅)

Does anyone have any new discoveries that could point us in a direction for where to start looking to get this fixed?

[AlpSha]

Same issue with firebase-functions 3.7.0

[partriv]

i had to rollback to node 8 and my old firebase-functions and firebase-admin that was specified in package-lock. Couldn't get this working for now... will come back to it later.

[kimroen]

I just wanted to chime in here and mention that we were able to get past this now. In our case, it turned out that with the latest firebase-admin and firebase-functions, we weren't getting this error any more. However, we were getting other Express-related type errors because of a change to how parameter queries are typed, so we were just assuming the build failures were the same as before.

I would strongly suggest that you try this again and have a proper look at the error messages to make sure that you are actually still seeing this specific error.

---

📝 Here is the error we were seeing - it's likely you'll run into this

[lubo08]

this export const api = functions.https.onRequest(app); not work for me. Even do this still getting error. `node_modules/firebase-functions/lib/apps.d.ts:33:21 - error TS7033: Property 'firebaseArgs' implicitly has type 'any', because its get accessor lacks a return type annotation.

33 private get firebaseArgs(); ~~~~~~~~~~~~

node_modules/firebase-functions/node_modules/@types/express/index.d.ts:103:54 - error TS2315: Type 'Response' is not generic.

103 export interface Response<ResBody = any> extends core.Response<ResBody> { }`

[kimroen]

@lubo08 Could you try doing a ls-command to check which version of the express types you are running?

npm ls "@types/express"

[lubo08]

functions@ /Users/..../workspace/sinvoicescloud/functions ├─┬ @types/[email protected] │ └── @types/[email protected] └─┬ [email protected] └── @types/[email protected]

[lubo08]

OK. I try several times remove node_modules folder and package-lock.json. Have no idea why but now it works. Probably I did some mistake with removing and install updated package.json .

[kimroen]

@lubo08 Great to hear! What does the ls command say now?

[lubo08]

@kimroen looks same for firebase-functions, maybe @types/cors with different version cause troubles? @types/[email protected] │ └── @types/[email protected] └─┬ [email protected] └── @types/[email protected]

[kimroen]

@lubo08 Yes, I think that is likely. Thanks!

[HathTech]

Any update?

[patrickgorrell]

Any updates to this?

[ValentinFunk]

    npm i --save-dev @types/[email protected] @types/[email protected] typescript@^4.0.2 
    npm i --save express@^4.17.1 firebase@^7.19.1 firebase-functions@^3.11.0
    npm uninstall --save-dev @types/cors

these work for us without errors

[NashIlli]

Hey! Any updates? Thanks a lot!

[hungtranpg]

Same issue when update firebase-functions from 3.3 to 3.13

[hyst3ric41]

After some research, installing "@types/node": "^14.0.1" solve the problem for me. Be careful to install this specific version, I've tried with the latest versions but seems like doing nothing. I'm serving Express on Cloud Functions to SSR and my package.json looks like the following:

{
  "name": "functions",
  "scripts": {
    "build": "tsc",
    "serve": "npm run build && firebase emulators:start --only functions",
    "shell": "npm run build && firebase functions:shell",
    "start": "npm run shell",
    "deploy": "firebase deploy --only functions",
    "logs": "firebase functions:log"
  },
  "engines": {
    "node": "14"
  },
  "main": "lib/index.js",
  "dependencies": {
    "firebase-admin": "^9.8.0",
    "firebase-functions": "^3.14.1"
  },
  "devDependencies": {
    "@types/express": "^4.17.13",
    "@types/express-serve-static-core": "^4.17.24",
    "@types/node": "^14.0.1",
    "firebase-functions-test": "^0.2.0",
    "typescript": "^4.1.5"
  },
  "private": true
}

Hey! Any updates? Thanks a lot!

[taeold]

Looks like there was incompatibility with old version of the SDK with Node types. If anyone is having similar issue, please open up a new issue instead.