firebase-functions
firebase-functions copied to clipboard
beforeUserSignedIn has field misspelled photoURL instead of photoUrl
Related issues
[REQUIRED] Version info
node: 20.18.0
firebase-functions: 6.0.1
firebase-tools: 13.25.0
firebase-admin: 12.6.0
[REQUIRED] Test case
export const beforecreated = beforeUserCreated(async () => {
return {
photoUrl: "https://url1.test.com",
photoURL: "https://url2.test.com",
};
});
[REQUIRED] Steps to reproduce
Create above blocking function and check which url is returned for photo url. its photoUrl and not photoURL.
[REQUIRED] Expected behavior
As per typescript interface it must return photoURL and not photoUrl
[REQUIRED] Actual behavior
photoURL must be returned
Were you able to successfully deploy your functions?
yes
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
Hi @mohankumarelec,
I have raised this issue internally with the team. I proposed either:
- Updating the documentation to use
photoURL, which would prevent a breaking change. - Renaming
photoURLtophotoUrl, just as you've done in your PR.
I believe we're going with option 1.