firebase-functions-test icon indicating copy to clipboard operation
firebase-functions-test copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Better types for auth.makeUserRecord

Open rhodgkins opened this issue 3 years ago • 5 comments

Description

Allowed partial typed UserRecord object to be specified for parameter of auth.makeUserRecord.

Code sample

N/A

rhodgkins avatar Aug 09 '21 08:08 rhodgkins

Can anyone review and, if happy, merge this in please?

rhodgkins avatar Sep 24 '21 12:09 rhodgkins

Bump @inlined & @taeold

rhodgkins avatar Oct 25 '21 08:10 rhodgkins

I can’t remember why I removed toJSON now :-/ I don’t think a simple Partial will be enough though as it needs to recurse down to the sub objects (like it does at the moment with metadata, etc.), otherwise they will need to be fully defined.

rhodgkins avatar Oct 26 '21 06:10 rhodgkins

I wonder if we should define RecursivePartial as demonstrated here (maybe in index.ts) and then use that in UserRecord and others. What do you think about that?

inlined avatar Oct 27 '21 17:10 inlined

Yeh that’s fine with me 👍

rhodgkins avatar Oct 28 '21 13:10 rhodgkins