firebase-functions-python icon indicating copy to clipboard operation
firebase-functions-python copied to clipboard

fix: Check for no microseconds in timestamp for pubsub message handler

Open koenmtb1 opened this issue 1 year ago • 6 comments

Fixes #160

koenmtb1 avatar Feb 14 '24 11:02 koenmtb1

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 14 '24 11:02 google-cla[bot]

I've verified this to work locally by overwriting the _message_handler with this version. It no longer throws any errors and because I had retries turned on it properly started processing any event that had this issue.

koenmtb1 avatar Feb 14 '24 12:02 koenmtb1

@koenmtb1 could you add tests for this?

exaby73 avatar Feb 16 '24 00:02 exaby73

Additionally, please fix the formatting errors

inlined avatar Feb 20 '24 18:02 inlined

Also, Google servers don't typically send microseconds that I'm aware of. Are you seeing problems in production or in the emulator?

inlined avatar Feb 20 '24 18:02 inlined

@inlined - Having encountered this error today, I can confirm that I'm seeing problems with this in production. @koenmtb1 - Following up on the testing and formatting requests above (from 9 to 10 weeks ago). It would be nice to get this merged so that others don't encounter this same issue.

dblake10 avatar May 01 '24 23:05 dblake10

Closing in favor of https://github.com/firebase/firebase-functions-python/pull/204

exaby73 avatar May 15 '24 09:05 exaby73