firebase-functions-python
firebase-functions-python copied to clipboard
fix: Check for no microseconds in timestamp for pubsub message handler
Fixes #160
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I've verified this to work locally by overwriting the _message_handler with this version. It no longer throws any errors and because I had retries turned on it properly started processing any event that had this issue.
@koenmtb1 could you add tests for this?
Additionally, please fix the formatting errors
Also, Google servers don't typically send microseconds that I'm aware of. Are you seeing problems in production or in the emulator?
@inlined - Having encountered this error today, I can confirm that I'm seeing problems with this in production. @koenmtb1 - Following up on the testing and formatting requests above (from 9 to 10 weeks ago). It would be nice to get this merged so that others don't encounter this same issue.
Closing in favor of https://github.com/firebase/firebase-functions-python/pull/204