firebase
[FR] ProGuard Rules Shouldn't Ignore Warnings?
Hello fantastic Firebase folks,
It looks like all the ProGuard specs start by ignoring all warnings for the project that uses them, with -ignorewarnings.
(To reproduce, run grep ignorewarnings external/firebase_cpp/libs/android/*.pro from the latest release.)
This seems...dangerous, and is pretty heavily discouraged by the ProGuard Manual and disallowed in Bazel for similar reasons.
Is it necessary? (Things seemed to work fine without in a quick test) And if not necessary, would you be open to removing -ignorewarnings?
Cheers, Chris
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
(I'd have tossed up a PR for this, but I couldn't see where it was coming from in the ProGuard generation)
We are going to mark this as a feature request for now. Looking over it, we aren't quite sure where that line is coming from either without doing a deeper dive into it. Also aren't sure of all the implications of removing that, though I will agree it does seem odd, and would probably be better to remove. Thanks for flagging this!
Sounds good. Thanks! I've changed the title to match the designation. Cheers!