firebase-cpp-sdk
firebase-cpp-sdk copied to clipboard
firebase
ReleaseDebugConfigSupport
Support multiple configuration https://cmake.org/cmake/help/v3.16/variable/CMAKE_CONFIGURATION_TYPES.html#variable:CMAKE_CONFIGURATION_TYPES https://cmake.org/cmake/help/v3.16/prop_tgt/MAP_IMPORTED_CONFIG_CONFIG.html
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Hi @crazyhappygame, sorry for the delay in getting back to you. Unfortunately, we have run into a couple roadblocks that have prevented us from setting up the repo to take in pull requests through GitHub (changes are being brought over from another repo, and it is currently one way, so this change would risk getting blown away). The change does look reasonable though, so if you are fine with it, I can replicate your change into that repo, and push it onto this.
@a-maurice @DellaBitta I checked the latest version 8.3 and those changes are still not there... Could you merge it?