firebase-cpp-sdk icon indicating copy to clipboard operation
firebase-cpp-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Ignore Android native build folder

Open a-maurice opened this issue 2 years ago • 3 comments

Description

Provide details of the change, and generalize the change in the PR title above.

When doing the Android build, native builds end up in .externalNativeBuild, so we should ignore that in the gitignore.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • [ ] Bug fix. Add the issue # below if applicable.
  • [ ] New feature. A non-breaking change which adds functionality.
  • [x] Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

a-maurice avatar Sep 20 '22 18:09 a-maurice

I've used git as an indicator that I should cleanup older transitory build files in this directory when starting on new features, etc.

Is there a way to clean this folder in our build system, too? Like cmake -clean or something?

DellaBitta avatar Sep 20 '22 18:09 DellaBitta

I've used git as an indicator that I should cleanup older transitory build files in this directory when starting on new features, etc.

Is there a way to clean this folder in our build system, too? Like cmake -clean or something?

I think adding it to the ignore will make the clean not clean it? I think gradle clean should do it, but I won't deny cleaning that folder can be confusing.

a-maurice avatar Sep 20 '22 19:09 a-maurice

I think git ignore wouldn't affect gradle clean. I just need to start remember to do it, I guess. :)

DellaBitta avatar Sep 20 '22 19:09 DellaBitta

❌  Integration test FAILED (but still ⏳  in progress)

Requested by @a-maurice on commit 915e5a39b67a3e99c927bd50dd7f6e86430731a8 Last updated: Thu Sep 22 15:21 PDT 2022 View integration test log & download artifacts

Failures Configs
functions [TEST] [ERROR] [Linux] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

github-actions[bot] avatar Sep 22 '22 20:09 github-actions[bot]