firebase-android-sdk
firebase-android-sdk copied to clipboard
Shorten the length of the Crashlytics folder prefix for long package names
Context in: b/338001446
📝 PRs merging into main branch
Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.
| 1 Warning | |
|---|---|
| :warning: | Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.) |
Generated by :no_entry_sign: Danger
Coverage Report 1
Affected Products
No changes between base commit (b4b096b) and merge commit (cd5989f).Test Logs
Unit Test Results
6 files - 942 6 suites - 942 14s :stopwatch: - 34m 24s 19 tests - 5 191 19 :heavy_check_mark: - 5 170 0 :zzz: - 21 0 :x: ±0 38 runs - 10 467 38 :heavy_check_mark: - 10 425 0 :zzz: - 42 0 :x: ±0
Results for commit 6aa1a75d. ± Comparison against base commit b4b096b5.
Size Report 1
Affected Products
firebase-crashlyticsType Base (b4b096b) Merge (cd5989f) Diff aar 409 kB 409 kB +3 B (+0.0%) apk (aggressive) 688 kB 688 kB -24 B (-0.0%) apk (release) 5.84 MB 5.84 MB -36 B (-0.0%)
Test Logs
Startup Time Report 1
Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.
Notes
- This report is for comparing the base commit (b4b096b) and the CI merge commit (cd5989f)
- Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
Startup Times
fire-clsDevice Statistics Distributions oriole-32 Percentile b4b096b cd5989f Diff Significant (?) p10 10.6 ±2 ms 9.99 ±3 ms -634 μs (-6.0%) NO p25 11.3 ±2 ms 10.6 ±3 ms -752 μs (-6.6%) NO p50 12.3 ±2 ms 11.4 ±3 ms -817 μs (-6.7%) NO p75 13.7 ±3 ms 12.6 ±3 ms -1.06 ms (-7.8%) NO p90 15.4 ±3 ms 14.2 ±4 ms -1.26 ms (-8.2%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
redfin-30 Percentile b4b096b cd5989f Diff Significant (?) p10 14.1 ±5 ms 14.8 ±6 ms +739 μs (+5.3%) NO p25 14.8 ±6 ms 15.6 ±7 ms +782 μs (+5.3%) NO p50 15.9 ±6 ms 16.6 ±8 ms +706 μs (+4.4%) NO p75 17.2 ±7 ms 17.8 ±8 ms +687 μs (+4.0%) NO p90 18.9 ±7 ms 20.0 ±9 ms +1.13 ms (+6.0%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
fire-rcDevice Statistics Distributions oriole-32 Percentile b4b096b cd5989f Diff Significant (?) p10 270 ±537 μs 100 ±56 μs -170 μs (-63.0%) NO p25 282 ±556 μs 106 ±59 μs -176 μs (-62.4%) NO p50 306 ±594 μs 118 ±73 μs -188 μs (-61.4%) NO p75 355 ±664 μs 144 ±90 μs -211 μs (-59.4%) NO p90 420 ±777 μs 183 ±93 μs -237 μs (-56.4%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
redfin-30 Percentile b4b096b cd5989f Diff Significant (?) p10 565 ±634 μs 401 ±324 μs -164 μs (-29.0%) NO p25 657 ±746 μs 499 ±447 μs -158 μs (-24.1%) NO p50 830 ±913 μs 682 ±663 μs -147 μs (-17.8%) NO p75 1.00 ±1 ms 851 ±836 μs -152 μs (-15.1%) NO p90 1.28 ±1 ms 1.20 ±1 ms -81.3 μs (-6.4%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
fire-sessionsDevice Statistics Distributions oriole-32 Percentile b4b096b cd5989f Diff Significant (?) p10 3.01 ±0.9 ms 2.63 ±0.6 ms -381 μs (-12.7%) NO p25 3.20 ±0.9 ms 2.80 ±0.6 ms -402 μs (-12.6%) NO p50 3.57 ±1 ms 3.14 ±0.7 ms -430 μs (-12.1%) NO p75 4.12 ±1 ms 3.72 ±0.7 ms -398 μs (-9.7%) NO p90 4.99 ±1 ms 4.32 ±0.8 ms -670 μs (-13.4%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
redfin-30 Percentile b4b096b cd5989f Diff Significant (?) p10 5.86 ±0.6 ms 6.64 ±1 ms +778 μs (+13.3%) NO p25 6.21 ±0.7 ms 7.27 ±2 ms +1.06 ms (+17.0%) NO p50 6.70 ±0.9 ms 8.13 ±2 ms +1.42 ms (+21.2%) NO p75 7.28 ±1 ms 9.34 ±4 ms +2.06 ms (+28.3%) NO p90 8.38 ±2 ms 11.3 ±5 ms +2.89 ms (+34.5%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
timeToInitialDisplayDevice Statistics Distributions oriole-32 Percentile b4b096b cd5989f Diff Significant (?) p10 200 ±6 ms 203 ±3 ms +3.30 ms (+1.7%) NO p25 206 ±8 ms 208 ±3 ms +2.49 ms (+1.2%) NO p50 214 ±12 ms 216 ±3 ms +2.73 ms (+1.3%) NO p75 224 ±20 ms 224 ±3 ms -386 μs (-0.2%) NO p90 233 ±23 ms 234 ±5 ms +888 μs (+0.4%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
redfin-30 Percentile b4b096b cd5989f Diff Significant (?) p10 246 ±12 ms 262 ±3 ms +16.1 ms (+6.5%) NO p25 252 ±12 ms 267 ±3 ms +15.5 ms (+6.2%) NO p50 259 ±14 ms 274 ±3 ms +15.0 ms (+5.8%) NO p75 268 ±19 ms 282 ±4 ms +14.4 ms (+5.4%) NO p90 281 ±29 ms 295 ±5 ms +14.2 ms (+5.1%) NO 20 test runs in comparison
Commit Test Runs b4b096b - 2024-06-28_16:25:54.390976_oqrt
- 2024-06-28_16:25:54.391032_dVvV
- 2024-06-28_16:25:54.391042_BiAz
- 2024-06-28_16:25:54.391050_dGvj
- 2024-06-28_16:25:54.391057_HTyQ
- 2024-06-28_16:25:54.391064_SiXR
- 2024-06-28_16:25:54.391071_dDAt
- 2024-06-28_16:25:54.391077_OcXT
- 2024-06-28_16:25:54.391084_hhYt
- 2024-06-28_16:25:54.391097_ceci
cd5989f - 2024-07-01_17:40:05.998049_rWSk
- 2024-07-01_17:40:05.998096_XfFf
- 2024-07-01_17:40:05.998107_zrnc
- 2024-07-01_17:40:05.998114_CMzi
- 2024-07-01_17:40:05.998121_wYID
- 2024-07-01_17:40:05.998128_CIQo
- 2024-07-01_17:40:05.998135_jUwf
- 2024-07-01_17:40:05.998141_LfzZ
- 2024-07-01_17:40:05.998148_ZlWN
- 2024-07-01_17:40:05.998155_seRz
We can't just change the path, we have to make a v3 so the sdk can clean up old files. So useV2FileSystem() becomes useV3FileSystem(), and the cleanupPreviousFileSystems needs to clean up v1 and v2.