firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

Add changelog entry for closing real-time background connections.

Open danasilver opened this issue 1 year ago β€’ 6 comments

danasilver avatar Feb 17 '24 00:02 danasilver

πŸ“ PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions[bot] avatar Feb 17 '24 00:02 github-actions[bot]

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (46cccc9) to 83.95% (9299729) by ?.

    33 individual files with coverage change

    FilenameBase (46cccc9)Merge (9299729)Diff
    AutoValue_ConfigUpdate.java?29.41%?
    Code.java?0.00%?
    ConfigAutoFetch.java?88.07%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?94.29%?
    ConfigFetchHandler.java?92.86%?
    ConfigFetchHttpClient.java?87.33%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigMetadataClient.java?92.31%?
    ConfigRealtimeHandler.java?40.00%?
    ConfigRealtimeHttpClient.java?67.59%?
    ConfigStorageClient.java?100.00%?
    ConfigUpdate.java?100.00%?
    ConfigUpdateListener.java?0.00%?
    ConfigUpdateListenerRegistration.java?0.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?91.13%?
    FirebaseRemoteConfigClientException.java?75.00%?
    FirebaseRemoteConfigException.java?95.65%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?68.42%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfig.kt?31.58%?
    RemoteConfigComponent.java?90.70%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?
    RolloutsStateFactory.java?95.24%?
    RolloutsStateSubscriptionsHandler.java?100.00%?

Test Logs

google-oss-bot avatar Feb 17 '24 00:02 google-oss-bot

Unit Test Results

βŸβ€„40 files  Β±0β€‚β€ƒβŸβ€„40 suites  Β±0   1m 8s :stopwatch: +2s 311 tests Β±0  311 :heavy_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0  634 runs  Β±0  634 :heavy_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0 

Results for commit 63fd6ea8. ± Comparison against base commit 46cccc9f.

github-actions[bot] avatar Feb 17 '24 00:02 github-actions[bot]

Size Report 1

Affected Products

  • base

    TypeBase (46cccc9)Merge (9299729)Diff
    apk (aggressive)?8.75 kB? (?)
    apk (release)?10.5 kB? (?)
  • firebase-config

    TypeBase (46cccc9)Merge (9299729)Diff
    aar?109 kB? (?)
    apk (aggressive)?266 kB? (?)
    apk (release)?4.81 MB? (?)
  • firebase-config-interop

    TypeBase (46cccc9)Merge (9299729)Diff
    aar?10.4 kB? (?)
    apk (aggressive)?24.6 kB? (?)
    apk (release)?2.00 MB? (?)

Test Logs

google-oss-bot avatar Feb 17 '24 00:02 google-oss-bot

Re: failed checks -

  • There's an issue with "Release note changes / build (pull request)" failing for several modules, and it does not block merging.
  • Smoke Tests should be unrelated - this PR has no code changes

danasilver avatar Feb 17 '24 00:02 danasilver

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (9299729) and the base commit (46cccc9) are not available.

No macrobenchmark data found for the base commit (46cccc9). Analysis for the CI merge commit (9299729) can be found at:

google-oss-bot avatar Feb 17 '24 00:02 google-oss-bot