firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

Remove unnecessary custom shadow annotations.

Open gsakakihara opened this issue 1 year ago • 5 comments

gsakakihara avatar Feb 06 '24 20:02 gsakakihara

Release note changes

No release note changes were detected. If you made changes that should be present in the next release, ensure you've added an entry in the appropriate CHANGELOG.md file(s).

github-actions[bot] avatar Feb 06 '24 20:02 github-actions[bot]

Size Report 1

Affected Products

No changes between base commit (d1fbda4) and merge commit (37d42ed).

Test Logs

google-oss-bot avatar Feb 06 '24 21:02 google-oss-bot

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.08% (d1fbda4) to 84.16% (37d42ed) by +0.08%.

    FilenameBase (d1fbda4)Merge (37d42ed)Diff
    FirebaseMessaging.java73.13%74.01%+0.88%

Test Logs

google-oss-bot avatar Feb 06 '24 21:02 google-oss-bot

Unit Test Results

  62 files   -    228    62 suites   - 228   5m 52s :stopwatch: -18s 475 tests  - 1 480  475 :heavy_check_mark:  - 1 462  0 :zzz:  - 18  0 :x: ±0  956 runs   - 3 016  956 :heavy_check_mark:  - 2 980  0 :zzz:  - 36  0 :x: ±0 

Results for commit ba60c825. ± Comparison against base commit d1fbda4b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 06 '24 21:02 github-actions[bot]

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fcm

    DeviceStatisticsDistributions
    oriole-32
    Percentiled1fbda437d42edDiffSignificant (?)
    p102.70 ±2 ms1.72 ±2 ms-978 μs (-36.3%)NO
    p252.89 ±2 ms1.84 ±2 ms-1.06 ms (-36.5%)NO
    p503.20 ±2 ms2.07 ±2 ms-1.13 ms (-35.3%)NO
    p753.65 ±2 ms2.33 ±2 ms-1.32 ms (-36.1%)NO
    p904.09 ±3 ms2.76 ±3 ms-1.33 ms (-32.6%)NO

    20 test runs in comparison
    CommitTest Runs
    d1fbda4
    • 2024-02-28_22:52:45.848372_tiEH
    • 2024-02-28_22:52:45.848399_OcpO
    • 2024-02-28_22:52:45.848406_zKMS
    • 2024-02-28_22:52:45.848411_TaHH
    • 2024-02-28_22:52:45.848415_FMOY
    • 2024-02-28_22:52:45.848422_iTTq
    • 2024-02-28_22:52:45.848431_VoYi
    • 2024-02-28_22:52:45.848439_CMJq
    • 2024-02-28_22:52:45.848452_ClJq
    • 2024-02-28_22:52:45.848459_dHPQ
    37d42ed
    • 2024-03-04_19:06:49.946158_dRVc
    • 2024-03-04_19:06:49.946196_RdbD
    • 2024-03-04_19:06:49.946208_VTyV
    • 2024-03-04_19:06:49.946216_FGlL
    • 2024-03-04_19:06:49.946225_njAC
    • 2024-03-04_19:06:49.946234_KTpu
    • 2024-03-04_19:06:49.946242_MSjS
    • 2024-03-04_19:06:49.946248_lkYr
    • 2024-03-04_19:06:49.946255_jcsE
    • 2024-03-04_19:06:49.946262_sQlB
    redfin-30
    Percentiled1fbda437d42edDiffSignificant (?)
    p101.74 ±2 ms1.61 ±1 ms-129 μs (-7.4%)NO
    p251.96 ±2 ms1.73 ±1 ms-230 μs (-11.7%)NO
    p502.20 ±2 ms1.91 ±1 ms-289 μs (-13.2%)NO
    p752.56 ±3 ms2.34 ±2 ms-220 μs (-8.6%)NO
    p903.14 ±4 ms3.03 ±3 ms-113 μs (-3.6%)NO

    20 test runs in comparison
    CommitTest Runs
    d1fbda4
    • 2024-02-28_22:52:45.848372_tiEH
    • 2024-02-28_22:52:45.848399_OcpO
    • 2024-02-28_22:52:45.848406_zKMS
    • 2024-02-28_22:52:45.848411_TaHH
    • 2024-02-28_22:52:45.848415_FMOY
    • 2024-02-28_22:52:45.848422_iTTq
    • 2024-02-28_22:52:45.848431_VoYi
    • 2024-02-28_22:52:45.848439_CMJq
    • 2024-02-28_22:52:45.848452_ClJq
    • 2024-02-28_22:52:45.848459_dHPQ
    37d42ed
    • 2024-03-04_19:06:49.946158_dRVc
    • 2024-03-04_19:06:49.946196_RdbD
    • 2024-03-04_19:06:49.946208_VTyV
    • 2024-03-04_19:06:49.946216_FGlL
    • 2024-03-04_19:06:49.946225_njAC
    • 2024-03-04_19:06:49.946234_KTpu
    • 2024-03-04_19:06:49.946242_MSjS
    • 2024-03-04_19:06:49.946248_lkYr
    • 2024-03-04_19:06:49.946255_jcsE
    • 2024-03-04_19:06:49.946262_sQlB
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentiled1fbda437d42edDiffSignificant (?)
    p10203 ±4 ms210 ±4 ms+6.57 ms (+3.2%)NO
    p25209 ±5 ms216 ±3 ms+7.24 ms (+3.5%)NO
    p50217 ±5 ms225 ±4 ms+8.08 ms (+3.7%)NO
    p75225 ±5 ms235 ±6 ms+10.8 ms (+4.8%)NO
    p90233 ±6 ms253 ±12 ms+20.4 ms (+8.8%)NO

    20 test runs in comparison
    CommitTest Runs
    d1fbda4
    • 2024-02-28_22:52:45.848372_tiEH
    • 2024-02-28_22:52:45.848399_OcpO
    • 2024-02-28_22:52:45.848406_zKMS
    • 2024-02-28_22:52:45.848411_TaHH
    • 2024-02-28_22:52:45.848415_FMOY
    • 2024-02-28_22:52:45.848422_iTTq
    • 2024-02-28_22:52:45.848431_VoYi
    • 2024-02-28_22:52:45.848439_CMJq
    • 2024-02-28_22:52:45.848452_ClJq
    • 2024-02-28_22:52:45.848459_dHPQ
    37d42ed
    • 2024-03-04_19:06:49.946158_dRVc
    • 2024-03-04_19:06:49.946196_RdbD
    • 2024-03-04_19:06:49.946208_VTyV
    • 2024-03-04_19:06:49.946216_FGlL
    • 2024-03-04_19:06:49.946225_njAC
    • 2024-03-04_19:06:49.946234_KTpu
    • 2024-03-04_19:06:49.946242_MSjS
    • 2024-03-04_19:06:49.946248_lkYr
    • 2024-03-04_19:06:49.946255_jcsE
    • 2024-03-04_19:06:49.946262_sQlB
    redfin-30
    Percentiled1fbda437d42edDiffSignificant (?)
    p10263 ±33 ms276 ±12 ms+12.7 ms (+4.8%)NO
    p25270 ±33 ms283 ±13 ms+12.9 ms (+4.8%)NO
    p50278 ±38 ms291 ±14 ms+12.4 ms (+4.4%)NO
    p75289 ±41 ms301 ±15 ms+12.7 ms (+4.4%)NO
    p90299 ±42 ms317 ±19 ms+17.7 ms (+5.9%)NO

    20 test runs in comparison
    CommitTest Runs
    d1fbda4
    • 2024-02-28_22:52:45.848372_tiEH
    • 2024-02-28_22:52:45.848399_OcpO
    • 2024-02-28_22:52:45.848406_zKMS
    • 2024-02-28_22:52:45.848411_TaHH
    • 2024-02-28_22:52:45.848415_FMOY
    • 2024-02-28_22:52:45.848422_iTTq
    • 2024-02-28_22:52:45.848431_VoYi
    • 2024-02-28_22:52:45.848439_CMJq
    • 2024-02-28_22:52:45.848452_ClJq
    • 2024-02-28_22:52:45.848459_dHPQ
    37d42ed
    • 2024-03-04_19:06:49.946158_dRVc
    • 2024-03-04_19:06:49.946196_RdbD
    • 2024-03-04_19:06:49.946208_VTyV
    • 2024-03-04_19:06:49.946216_FGlL
    • 2024-03-04_19:06:49.946225_njAC
    • 2024-03-04_19:06:49.946234_KTpu
    • 2024-03-04_19:06:49.946242_MSjS
    • 2024-03-04_19:06:49.946248_lkYr
    • 2024-03-04_19:06:49.946255_jcsE
    • 2024-03-04_19:06:49.946262_sQlB

google-oss-bot avatar Feb 06 '24 21:02 google-oss-bot