firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

WIP - Add a screenshot-based trigger for in-app feedback

Open lfkellogg opened this issue 2 years ago • 2 comments

Also has some refactoring to, among other things, allow the passing of a screenshot URI to the startFeedback() API.

lfkellogg avatar Sep 20 '22 21:09 lfkellogg

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 76.50% (eb9414a) to 76.42% (362f730) by -0.08%.

    FilenameBase (eb9414a)Merge (362f730)Diff
    AutoValue_ImageUtils_ImageSize.java30.00%35.00%+5.00%
    FirebaseAppDistributionImpl.java92.86%92.31%-0.55%
    ImageUtils.java95.45%96.00%+0.55%
    LogWrapper.java53.33%62.50%+9.17%
    ScreenshotTaker.java65.63%66.67%+1.04%
    TesterApiHttpClient.java89.19%89.47%+0.28%
  • firebase-appdistribution-api

    Overall coverage changed from 60.91% (eb9414a) to 57.76% (362f730) by -3.15%.

    FilenameBase (eb9414a)Merge (362f730)Diff
    FirebaseAppDistributionProxy.java73.33%57.89%-15.44%
    FirebaseAppDistributionStub.java79.55%76.09%-3.46%

Test Logs

google-oss-bot avatar Sep 20 '22 21:09 google-oss-bot

The public api surface has changed for the subproject firebase-appdistribution-api: error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Sep 20 '22 21:09 google-oss-bot

The public api surface has changed for the subproject firebase-appdistribution-api: error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Sep 22 '22 19:09 google-oss-bot

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (eb9414a)Merge (362f730)Diff
    aar153 kB154 kB+1.49 kB (+1.0%)
    apk (aggressive)881 kB882 kB+856 B (+0.1%)
    apk (release)2.01 MB2.01 MB+960 B (+0.0%)
  • firebase-appdistribution-api

    TypeBase (eb9414a)Merge (362f730)Diff
    aar14.4 kB14.7 kB+247 B (+1.7%)
    apk (release)689 kB689 kB+260 B (+0.0%)

Test Logs

google-oss-bot avatar Sep 22 '22 19:09 google-oss-bot

The public api surface has changed for the subproject firebase-appdistribution-api: error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Sep 22 '22 19:09 google-oss-bot

The public api surface has changed for the subproject firebase-appdistribution-api: error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod] error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(int,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Sep 23 '22 13:09 google-oss-bot

The public api surface has changed for the subproject firebase-appdistribution-api: error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod] error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(int,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Sep 23 '22 13:09 google-oss-bot

The public api surface has changed for the subproject firebase-appdistribution-api: error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod] error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(int,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Sep 23 '22 13:09 google-oss-bot