firebase-android-sdk
firebase-android-sdk copied to clipboard
firebase
Resolve strict mode violations in firebase-messaging
Part of a larger effort to resolve and prevent strict mode violations for eager components.
| 1 Warning | |
|---|---|
| :warning: | Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.) |
Generated by :no_entry_sign: Danger
Coverage Report 1
Affected Products
No changes between base commit (0c11f12) and merge commit (21d995a).Test Logs
- Base (0c11f12): https://github.com/firebase/firebase-android-sdk/actions/runs/3054900156
- Merge (21d995a): https://github.com/firebase/firebase-android-sdk/actions/runs/3056092099
Unit Test Results
27 files - 367 27 suites - 367 3m 48s :stopwatch: - 14m 28s 474 tests - 4 243 474 :heavy_check_mark: - 4 219 0 :zzz: - 22 0 :x: - 2 474 runs - 4 259 474 :heavy_check_mark: - 4 235 0 :zzz: - 22 0 :x: - 2
Results for commit 988669bf. ± Comparison against base commit 0c11f12d.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Size Report 1
Affected Products
baseType Base (0c11f12) Merge (21d995a) Diff apk (aggressive) ? 8.39 kB ? (?) apk (release) ? 8.65 kB ? (?) firebase-annotationsType Base (0c11f12) Merge (21d995a) Diff apk (aggressive) ? 8.39 kB ? (?) apk (release) ? 8.89 kB ? (?) firebase-commonType Base (0c11f12) Merge (21d995a) Diff aar ? 50.1 kB ? (?) apk (aggressive) ? 85.1 kB ? (?) apk (release) ? 683 kB ? (?) firebase-componentsType Base (0c11f12) Merge (21d995a) Diff aar ? 42.8 kB ? (?) apk (aggressive) ? 8.68 kB ? (?) apk (release) ? 31.9 kB ? (?) firebase-datatransportType Base (0c11f12) Merge (21d995a) Diff aar ? 4.88 kB ? (?) apk (aggressive) ? 131 kB ? (?) apk (release) ? 770 kB ? (?) firebase-encodersType Base (0c11f12) Merge (21d995a) Diff apk (aggressive) ? 8.68 kB ? (?) apk (release) ? 15.3 kB ? (?) firebase-encoders-jsonType Base (0c11f12) Merge (21d995a) Diff aar ? 10.7 kB ? (?) apk (aggressive) ? 8.68 kB ? (?) apk (release) ? 20.1 kB ? (?) firebase-encoders-protoType Base (0c11f12) Merge (21d995a) Diff apk (aggressive) ? 8.68 kB ? (?) apk (release) ? 21.6 kB ? (?) firebase-installationsType Base (0c11f12) Merge (21d995a) Diff aar ? 54.9 kB ? (?) apk (aggressive) ? 86.4 kB ? (?) apk (release) ? 706 kB ? (?) firebase-installations-interopType Base (0c11f12) Merge (21d995a) Diff aar ? 8.06 kB ? (?) apk (aggressive) ? 65.0 kB ? (?) apk (release) ? 651 kB ? (?) firebase-messagingType Base (0c11f12) Merge (21d995a) Diff aar ? 142 kB ? (?) apk (aggressive) ? 440 kB ? (?) apk (release) ? 1.14 MB ? (?) transport-apiType Base (0c11f12) Merge (21d995a) Diff aar ? 6.74 kB ? (?) apk (aggressive) ? 8.68 kB ? (?) apk (release) ? 14.9 kB ? (?) transport-backend-cctType Base (0c11f12) Merge (21d995a) Diff aar ? 53.6 kB ? (?) apk (aggressive) ? 58.2 kB ? (?) apk (release) ? 105 kB ? (?) transport-runtimeType Base (0c11f12) Merge (21d995a) Diff aar ? 178 kB ? (?) apk (aggressive) ? 44.0 kB ? (?) apk (release) ? 83.0 kB ? (?)
Test Logs
Just to clarify, this isn't actually resolving any strict mode violations, right? This appears to be adding a new test to prevent any new strict mode violations from being added in the future? If so, could you change the commit message to reflect that? I'm slightly concerned that someone just looking at the commit messages could think that there was a problem before and misdiagnose a strict mode issue, believing that it was caused by FCM and not identifying the actual cause.
Firebase squashes commits so I changed the PR name and it'll use that instead of what I used for my branch