add coroutines-play-services as a transitive dep to firebase-common-ktx

[thatfiredev]

(Googlers see go/suspend-ktx-firebase-android)

[github-actions[bot]]

Unit Test Results

   395 files  +  5     395 suites  +5   18m 44s :stopwatch: +43s 4 715 tests +15  4 693 :heavy_check_mark: +17  22 :zzz: ±0  0 :x:  - 2  4 731 runs  +15  4 709 :heavy_check_mark: +17  22 :zzz: ±0  0 :x:  - 2 

Results for commit 095f0483. ± Comparison against base commit ed10eb5e.

:recycle: This comment has been updated with latest results.

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-appcheck-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	349 kB	356 kB	+7.56 kB (+2.2%)
  apk (release)	1.54 MB	1.92 MB	+378 kB (+24.6%)

• firebase-appdistribution-api-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	102 kB	110 kB	+7.56 kB (+7.4%)
  apk (release)	1.25 MB	1.63 MB	+376 kB (+30.1%)

• firebase-common-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	101 kB	109 kB	+7.56 kB (+7.5%)
  apk (release)	1.24 MB	1.62 MB	+375 kB (+30.2%)

• firebase-config-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	115 kB	118 kB	+3.46 kB (+3.0%)
  apk (release)	1.30 MB	1.67 MB	+376 kB (+29.0%)

• firebase-crashlytics-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	233 kB	237 kB	+3.46 kB (+1.5%)
  apk (release)	1.45 MB	1.83 MB	+376 kB (+25.9%)

• firebase-database-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	351 kB	354 kB	+3.47 kB (+1.0%)
  apk (release)	1.70 MB	2.08 MB	+378 kB (+22.3%)

• firebase-dynamic-links-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	351 kB	355 kB	+3.47 kB (+1.0%)
  apk (release)	1.54 MB	1.92 MB	+376 kB (+24.4%)

• firebase-firestore-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	512 kB	512 kB	+814 B (+0.2%)
  apk (release)	4.26 MB	4.26 MB	+4.22 kB (+0.1%)

• firebase-functions-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	415 kB	418 kB	+3.47 kB (+0.8%)
  apk (release)	1.77 MB	2.15 MB	+376 kB (+21.3%)

• firebase-inappmessaging-display-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	1.52 MB	1.52 MB	+3.46 kB (+0.2%)
  apk (release)	5.17 MB	5.55 MB	+374 kB (+7.2%)

• firebase-inappmessaging-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	681 kB	684 kB	+3.47 kB (+0.5%)
  apk (release)	3.92 MB	4.29 MB	+376 kB (+9.6%)

• firebase-installations-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	103 kB	111 kB	+7.56 kB (+7.3%)
  apk (release)	1.27 MB	1.64 MB	+374 kB (+29.5%)

• firebase-messaging-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	456 kB	460 kB	+3.46 kB (+0.8%)
  apk (release)	1.70 MB	2.08 MB	+379 kB (+22.3%)

• firebase-ml-modeldownloader-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	160 kB	163 kB	+3.46 kB (+2.2%)
  apk (release)	1.38 MB	1.76 MB	+378 kB (+27.3%)

• firebase-perf-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	1.05 MB	1.05 MB	+3.47 kB (+0.3%)
  apk (release)	3.03 MB	3.41 MB	+377 kB (+12.4%)

• firebase-storage-ktx

  Type	Base (ed10eb5)	Merge (d77b846)	Diff
  apk (aggressive)	350 kB	354 kB	+3.46 kB (+1.0%)
  apk (release)	1.57 MB	1.95 MB	+377 kB (+24.0%)

Test Logs

• Base (ed10eb5): https://github.com/firebase/firebase-android-sdk/actions/runs/3103127720
• Merge (d77b846): https://github.com/firebase/firebase-android-sdk/actions/runs/3109466477

1. https://storage.googleapis.com/firebase-sdk-metric-reports/2YdE3XekrE.html

[thatfiredev]

I'm slightly concerned with the increased size shown in the bot report above. Seems like adding the library as a transitive dependency adds ~390kB to every ktx module - to me it is a big bump for such a small addition. I'll check if we can expose only the .await() function instead of the whole library to see if it makes any difference in terms of size.

Update: No size difference, probably because we're including the library anyway. I'll proceed with the size bump, I guess that's the price to pay to get coroutines support out of the box.

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-database

  Overall coverage changed from 50.17% (ed10eb5) to 50.15% (d77b846) by -0.02%.

  Filename	Base (ed10eb5)	Merge (d77b846)	Diff
  DoubleNode.java	100.00%	88.24%	-11.76%

• firebase-firestore

  Overall coverage changed from 44.25% (ed10eb5) to 44.26% (d77b846) by +0.00%.

  Filename	Base (ed10eb5)	Merge (d77b846)	Diff
  DeleteMutation.java	90.48%	95.24%	+4.76%

Test Logs

• Base (ed10eb5): https://github.com/firebase/firebase-android-sdk/actions/runs/3103127720
• Merge (d77b846): https://github.com/firebase/firebase-android-sdk/actions/runs/3109466477

1. https://storage.googleapis.com/firebase-sdk-metric-reports/Dpe7KbC4VA.html

[thatfiredev]

~I'm holding this until #3974 gets merged. I think it would be better if we release with the latest version of Kotlin + latest version of kotlinx-coroutines-play-services .~

[thatfiredev]

@vkryachko Can I merge this?

Also since it bumps firebase-common, does it mean we'll have to release all SDKs? Or only the ones that have methods returning Tasks? But since it's a fireconf launch, I guess releasing them all wouldn't be so bad.

[vkryachko]

Sure, go ahead and merge. Yeah, we will have to release everyone with tasks. Can you coordinate with @VinayGuthal on the release?

[thatfiredev]

@vkryachko will do. Thanks!

[thatfiredev]

@vkryachko GitHub won't let me merge this, it says "Required statuses must pass before merging", I'm not sure why.

[vkryachko]

CI Tests / Unit Tests (:firebase-common) (pull_request) Failing after 4m

You should click "Rerun failed jobs" inside the failed workflow

[thatfiredev]

@vkryachko I checked the logs and noticed that the failing check was the flaky test which got fixed recently. I just had to sync with master, thanks for pointing me in the right direction.