firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

Outdated Glide dependency causing Gradle lint to throw error

Open ArcherEmiya05 opened this issue 3 years ago • 8 comments

[READ] Step 1: Are you in the right place?

Issues filed here should be about bugs in the code in this repository. If you have a general question, need help debugging, or fall into some other category use one of these other channels:

  • For general technical questions, post a question on StackOverflow with the firebase tag.
  • For general Firebase discussion, use the firebase-talk google group.
  • For help troubleshooting your application that does not fall under one of the above categories, reach out to the personalized Firebase support channel.

[REQUIRED] Step 2: Describe your environment

  • Android Studio version: Electric Eel
  • Firebase Component: In-App Messaging
  • Component version: 20.1.2

[REQUIRED] Step 3:

Running ./gradlew lint is failing due to outdated Glide version

> Task :app:libs:AndroidFirebase:lintDebug FAILED
C:\Users\user\.gradle\caches\transforms-3\b8c366a3553feb6b317d2c08d3b5866e\transformed\jetified-glide-4.11.0\jars\classes.jar: Error: When targeting Android 13 or higher, posting a pe
rmission requires holding the POST_NOTIFICATIONS permission (usage from com.bumptech.glide.request.target.NotificationTarget) [NotificationPermission]

   Explanation for issues of type "NotificationPermission":
   When targeting Android 13 and higher, posting permissions requires holding
   the runtime permission android.permission.POST_NOTIFICATIONS.

1 errors, 0 warnings

Steps to reproduce:

Add the dependency on your project api 'com.google.firebase:firebase-inappmessaging-display-ktx:20.1.2'

Relevant Code:

N/A

ArcherEmiya05 avatar Jul 28 '22 10:07 ArcherEmiya05

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

google-oss-bot avatar Jul 28 '22 10:07 google-oss-bot

Thanks for reporting, @ArcherEmiya05. If I'm not mistaken, I think Glide has to add this permission on their side. Then we can update the inappmessaging component to use the latest version of the Glide library which contains the permission. Could you open an issue on their repo? Thanks!

argzdev avatar Jul 28 '22 11:07 argzdev

Thanks for reporting, @ArcherEmiya05. If I'm not mistaken, I think Glide has to add this permission on their side. Then we can update the inappmessaging component to use the latest version of the Glide library which contains the permission. Could you open an issue on their repo? Thanks!

Is there a way to suppress this lint for now? It became a blocker on our end and we cannot get any response from the Glide team as of the moment. Thanks

ArcherEmiya05 avatar Jul 29 '22 16:07 ArcherEmiya05

Thanks for reporting, @ArcherEmiya05. If I'm not mistaken, I think Glide has to add this permission on their side. Then we can update the inappmessaging component to use the latest version of the Glide library which contains the permission. Could you open an issue on their repo? Thanks!

Is there a way to suppress this lint for now? It became a blocker on our end and we cannot get any response from the Glide team as of the moment. Thanks

Oh I already find the issue id its 'NotificationPermission'

ArcherEmiya05 avatar Jul 29 '22 16:07 ArcherEmiya05

We'll have to wait for Glide to resolve it on their side. Also were you able to suppress the lint issue? I think you should be able to suppress it via this Stack Overflow link:

android {
    lintOptions {
        // TODO: remove below once we have time to update entire logic.
        disable 'some_warning_id'
    }
}

Though I haven't tested this on my side yet. I'm having problems with setting up compileSdk 33. Anyway, let me know if this works. Thanks!

argzdev avatar Jul 29 '22 20:07 argzdev

Hey @ArcherEmiya05. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

google-oss-bot avatar Aug 05 '22 01:08 google-oss-bot

I'm tracking the progress on Glide's side in https://github.com/bumptech/glide/issues/4850

thatfiredev avatar Aug 05 '22 10:08 thatfiredev

Removing NI tag to avoid closure for now.

argzdev avatar Aug 05 '22 10:08 argzdev