firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

FIAM: Invoke launchUriIntent only if needed

Open garispe opened this issue 2 years ago • 2 comments

Related issue: #3056

garispe avatar May 12 '22 04:05 garispe

Hi @garispe. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-bot avatar May 12 '22 04:05 google-oss-bot

As mentioned in the issue comment here: https://github.com/firebase/firebase-android-sdk/issues/3056#issuecomment-1127993892 unfortunately we cannot take in this change for the time being now as this is going to be a change in functionality (and not a bug fix) and will be considered as a new feature from our side which needs evaluation and approval. We will add this to our feature backlog and you might be able to see something similar in our feature releases.

eldhosembabu avatar May 16 '22 18:05 eldhosembabu