firebase-admin-python icon indicating copy to clipboard operation
firebase-admin-python copied to clipboard

feat(appcheck): Add consumable token verification support

Open lahirumaramba opened this issue 1 month ago • 4 comments

This PR adds support for App Check token consumption (replay protection) to the app_check.verify_token() API

lahirumaramba avatar Nov 28 '25 00:11 lahirumaramba

Summary of Changes

Hello @lahirumaramba, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant security enhancement to the Firebase Admin SDK's App Check functionality. It allows developers to enable replay protection for App Check tokens by providing a new consume option in the verify_token API. This ensures that tokens, once verified, can be marked as consumed on the backend, preventing malicious actors from reusing them in subsequent requests and bolstering the integrity of client-server interactions.

Highlights

  • App Check Token Consumption: The app_check.verify_token() API now supports an optional consume parameter to enable replay protection for App Check tokens.
  • HTTP Client Integration: An internal HTTP client (_http_client.JsonHttpClient) has been integrated into the _AppCheckService to facilitate communication with the App Check backend for token consumption.
  • Replay Protection Logic: A new private method, _verify_replay_protection, was added to handle the API call to the App Check backend to check and consume tokens, returning an alreadyConsumed status.
  • Claims Augmentation: When consume is set to True, the verified token claims will now include an already_consumed boolean field indicating if the token was previously used.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 28 '25 00:11 gemini-code-assist[bot]

@gemini-code-assist review

lahirumaramba avatar Nov 28 '25 00:11 lahirumaramba

@gemini-code-assist review

lahirumaramba avatar Nov 28 '25 01:11 lahirumaramba

@gemini-code-assist review

lahirumaramba avatar Nov 28 '25 01:11 lahirumaramba