firebase-admin-python icon indicating copy to clipboard operation
firebase-admin-python copied to clipboard

[FR][FCM] HTTP2 support for sendEach

Open Klemenceo opened this issue 9 months ago • 11 comments

Hello,

With the new FCM v1 http endpoints, support for batching was removed. The solution for large volume is now topics (but that leave you with generic messages) and using HTTP2 (just like APNs does) to benefit from multiplexing.

The current implementation uses requests, which doesn't support HTTP2, and uses a ThreadPool as a means of doing concurrent sends, but you still pay for the HTTP layer on each send.

Are there plan to use something like hyperx in the future to switch sendEach to, in order to benefit from http2 multiplexing.

Thanks in advance.

Klemenceo avatar May 10 '24 14:05 Klemenceo

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar May 10 '24 14:05 google-oss-bot

+1 - this has a pretty urgent timeline with the june 20th deprecation of the existing batch send.

davidemerritt avatar May 13 '24 13:05 davidemerritt

Hi Folks, We are aware of these issues and working to address them.

Currently, support for HTTP/2 in Node.js is underway and our next focus is exploring similar options for Java, Python and the remaining SDKs. We will use this issue to track any progress here.

We can't provide a timeline for the completion of these projects but we are working to have these resolved as soon as we can and appreciate your continued patience as we do so.

jonathanedey avatar May 14 '24 13:05 jonathanedey

Will this be resolved prior to the june 20th cutoff for existing legacy endpoints? This swapover doesn't provide a reasonable migration strategy without this being implemented.

davidemerritt avatar May 16 '24 18:05 davidemerritt

I was going to make the same feature request, glad this is a known issue 🙏🏼

Tom3652 avatar May 20 '24 12:05 Tom3652

+1 - this has a pretty urgent timeline with the june 20th deprecation of the existing batch send.

Thankfully Google heard the cries of developers of every single firebase-admin-xyz repository pointing out the problems with the migration and came up with a working solution before the deadline. (Edit: this is sarcasm).

jagerman avatar Jun 20 '24 21:06 jagerman

+1 - this has a pretty urgent timeline with the june 20th deprecation of the existing batch send.

Thankfully Google heard the cries of developers of every single firebase-admin-xyz repository pointing out the problems with the migration and came up with a working solution before the deadline.

@jagerman may i ask what solution is that? i can't find it

jhkim-grip avatar Jul 03 '24 06:07 jhkim-grip

@jagerman may i ask what solution is that? i can't find it

That was sarcasm. As for an actual solution, https://github.com/olucurious/pyfcm is probably the option as Google apparently isn't interested it maintaining their tools.

jagerman avatar Jul 07 '24 14:07 jagerman

I was going to create the same FR.

vivekshah1801 avatar Jul 22 '24 09:07 vivekshah1801

Any updates?

dpereiraegoi avatar Sep 24 '24 17:09 dpereiraegoi

@jagerman may i ask what solution is that? i can't find it

That was sarcasm. As for an actual solution, https://github.com/olucurious/pyfcm is probably the option as Google apparently isn't interested it maintaining their tools.

So this works ? Has anyone tried this ?

Jay2109 avatar Sep 24 '24 19:09 Jay2109

This was the worse decision who Google/Firebase made. The service has become much worse, and confidence in the product has worsened. when a decision is made so that the service performs again ?

dpereiraegoi avatar Oct 25 '24 17:10 dpereiraegoi