firebase-admin-python icon indicating copy to clipboard operation
firebase-admin-python copied to clipboard

HTTPResponse strict attribute gone in urllib3>=2.0.0

Open MadameMinty opened this issue 1 year ago • 5 comments

  • Operating System version: Debian 11
  • Firebase SDK version: 6.1.0
  • Firebase Product: auth
  • Python version: 3.11.3
  • Pip version: 23.1.2

Steps to reproduce:

firebase-admin==6.1.0 package requires urllib3<3,>=1.21.1 and so pip installs urllib3==2.0.2, but with urllib3>=2.0.0, which removed attribute 'strict' from 'HTTPResponse' object, firebase_admin.auth.verify_id_token(token) raises an error AttributeError: 'HTTPResponse' object has no attribute 'strict'.

Relevant Code:

import firebase_admin
from firebase_admin import auth
cred = firebase_admin.credentials.Certificate(GOOGLE_APPLICATION_CREDENTIALS)
firebase_admin.initialize_app(cred)
firebase_admin.auth.verify_id_token(token)
...
File "\Lib\site-packages\cachecontrol\serialize.py", line 54, in dumps
    u"strict": response.strict,
               ^^^^^^^^^^^^^^^
AttributeError: 'HTTPResponse' object has no attribute 'strict'

MadameMinty avatar May 04 '23 16:05 MadameMinty

I have forced urllib3==1.26.15 in the meantime.

Tom3652 avatar May 05 '23 13:05 Tom3652

Confirmed the same issue and pinning urllib3 to 1.26.15 works for now.

davidtaddei avatar May 08 '23 07:05 davidtaddei

Thanks, urllib3 to 1.26.15 works well

JefersonParraVeredata avatar May 12 '23 17:05 JefersonParraVeredata

Any updates on this issue? (We use urllib3<2.0.0) as a workaround)

joente avatar Apr 17 '24 11:04 joente