firebase-admin-python icon indicating copy to clipboard operation
firebase-admin-python copied to clipboard

Add rate limiting exceptions

Open skion opened this issue 2 years ago • 2 comments

This adds two exception types to enable users to detect rate limited calls which were previously swallowed and converted into a generic InvalidArgumentError, making it impossible to detect rate limiting situations and pass that information through to the end user.

This is being discussed in #666.

I chose to inherit from the ResourceExhaustedError base exception, which seemed to make most sense.

skion avatar Apr 13 '23 20:04 skion

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 13 '23 20:04 google-cla[bot]

@pragatimodi Since you are assigned to #666, would you be able to check this out?

skion avatar May 01 '23 12:05 skion

@jonathanedey I see you are mostly maintaining this repo now, is this something you could have a look at?

skion avatar Feb 27 '24 09:02 skion