firebase-admin-python icon indicating copy to clipboard operation
firebase-admin-python copied to clipboard

[FR] Type hint the source code

Open takos22 opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. When developing with this library, I constantly have to type hint variables returned by the functions, so my autocompleter suggests the right properties and for cleaner code.

Describe the solution you'd like It would be great if you could type hint the library or at least the public API in order to help type checkers, autocompleters and collaboration.

Describe alternatives you've considered None

Additional context None

takos22 avatar Sep 01 '21 20:09 takos22

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar Sep 01 '21 20:09 google-oss-bot

Hi @takos22, Thank you for the feature request! We agree that this will be a great addition to improve the SDK. While I cannot promise you a timeline at the moment, we will use this github issue to track the progress in the future.

In the meantime, you can also help us speed things up by providing PRs! :)

lahirumaramba avatar Sep 01 '21 22:09 lahirumaramba

Do you have any progress on it? I still get infrastructure\push_notifications.py:7: error: Skipping analyzing "firebase_admi n": module is installed, but missing library stubs or py.typed marker error on mypy :(

Mowinski avatar Jun 14 '23 13:06 Mowinski

@lahirumaramba, maybe you can add py.typed file to the library? This will remove the message from mypy. And then add types.

heckad avatar Aug 17 '23 13:08 heckad