firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

[FR] Support for defaultSupportedIdpConfigs

Open IainAdams opened this issue 5 years ago • 4 comments

Is your feature request related to a problem? Please describe. The REST/GRPC API provides the ability to manage defaultSupportedIdpConfigs, however, this doesn't seem available from the Admin SDK. Please could you add support for these types of IDPs.

Describe the solution you'd like Similar to being able to manage SAML and OIDC providers, please add into the SDK methods for managing default supported idp configs.

Describe alternatives you've considered Calling the REST/gRPC APIs separately but this involves having to handle all the API handling framework already being completed by the Admin SDK.

IainAdams avatar Apr 13 '20 13:04 IainAdams

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar Apr 13 '20 13:04 google-oss-bot

This is something we want to eventually support but will likely come later in the future.

bojeil-google avatar Apr 13 '20 17:04 bojeil-google

It seems like such an easy thing to add in as basically so similar to the existing OIDC and SAML features. I'll try and do a PR although I am currently having issues building v8.10.0 with Node v12.13.0 and npm 6.12.0. I know you say it supports v8.x + but have you tried building against Node v12?

IainAdams avatar Apr 13 '20 19:04 IainAdams

We have some tests that won't build/run on Node 12 (see #739). So you cannot currently develop on Node 12.

Also, we cannot accept any PRs for this functionality until the Firebase Auth team decides to officially support it in the SDK. According to the comment by @bojeil-google it appears they are still thinking about it. Therefore before you invest time into implementing any new code, I'd advise you to submit a feature request at https://firebase.google.com/support so that the Auth team can prioritize this accordingly.

hiranya911 avatar Apr 13 '20 19:04 hiranya911

@lahirumaramba is there any news on the support for this feature?

IchordeDionysos avatar Apr 14 '23 13:04 IchordeDionysos