firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

feat: add field to webpush options to allow for Declarative Web Push messages

Open acrobid opened this issue 9 months ago • 4 comments

See issue here:

https://github.com/firebase/firebase-admin-node/issues/2892

Spec proposal:

See https://pr-preview.s3.amazonaws.com/w3c/push-api/pull/385.html#declarative-push-message

API Changes

This change allows for a new optional property in the webpush options, and will not affect existing projects.

acrobid avatar Apr 07 '25 05:04 acrobid

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 07 '25 05:04 google-cla[bot]

Hey @acrobid, thank you for your contribution we appreciate it! I don't think this feature is currently supported by the BE REST service so adding it to the SDK wouldn't address the issue.

Hey @chong-shao could you add more context here, please? Thank you!

lahirumaramba avatar Jul 09 '25 20:07 lahirumaramba

Yes, please refer to https://github.com/firebase/firebase-admin-node/issues/2892#issuecomment-3054019669 for context

chong-shao avatar Jul 09 '25 22:07 chong-shao

My understand is that declarative web push has now landed in the specifications.

https://github.com/mdn/browser-compat-data/pull/28000

acrobid avatar Oct 17 '25 04:10 acrobid