firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

[FR] Auth: Update user details and custom claims in the same request

Open brettwillis opened this issue 3 years ago • 2 comments

Currently, the custome user claims can be updated with setCustomUserClaims(), and the user details can be updated with updateUser().

Both use same /accounts:update REST API under the hood.

Is there a particular reason why the updateUser() method does not allow updating the custom claims even though it is possible in the underlying REST API? A follow up point is: if the updateUser() method has this functionalitly, then the setCustomUserClaims() would become obsolete (just a convenience wrapper).

I'd like to be able to include a customClaims field in the UpdateRequest interface, so that, if needed, we can update the user's details and claims in a single request. Currently we need two separate network requests to do this.

Let me know, and I can help with a PR if you want.

brettwillis avatar Aug 18 '22 01:08 brettwillis

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

google-oss-bot avatar Aug 18 '22 01:08 google-oss-bot

Side question: There seems to be a very low request rate quota on this /accounts:update API. I can't find it explicitly stated but it feels like 10 req/second, as per the account delete rate quota. Can you confirm what the quota is for this API?

This only makes it more important to be able to combine requests.

brettwillis avatar Aug 22 '22 20:08 brettwillis