firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

add: error handling in firestore-internal for version extension

Open Seung-o opened this issue 2 years ago • 1 comments

Discussion

  • Bug: Async Problem

I think firebase-internal.ts has async problem. It goes to if-else state before credential is created. So, in my case, I normally send credential in nestJS project with applicationDefault() method and credential was consoled out to be instance ServiceAccountCredential, but it gave error.

So, I suggest using try-catch statement in firestore-internal.ts and it would handle origin error. Also, in 'else' case It returns original credential.

Testing

  • I did all the test
  • Success percentage was 99.4 % ( 3 errors occurred )
  • 3 errors was engaged with FirestoreSerivce constructor, but i did not modify it.

API Changes

  • There is no API Changes.

Seung-o avatar Aug 01 '22 07:08 Seung-o

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 01 '22 07:08 google-cla[bot]