firebase-admin-dotnet
firebase-admin-dotnet copied to clipboard
firebase
[FR] Missing MultiFactor property in UserRecord
Hi, The MultiFactor property is missing in the .NET (and Java) implementation of UserRecord. Other implementations like Go, Python, and Node already have it.
While we wait for it to be added, is there any recommendation to get the raw response returned by the accounts:lookup call?
Thanks
I found a few problems with this issue:
- I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
- This issue does not seem to follow the issue template. Make sure you provide all the required information.
In the meantime, I ended up creating a custom HttpClientFactory to add a custom DelegatingHandler with a Channel. And subscribe to it to capture the Response content. Any other temporary suggestion is welcome.
Hey! I made a fork for this here and started working on this so i'll make a pr when that is done.
There are some new things I need to do, like adding a list property to userRecordArgs, but that should be fine.
There should not be any other problem in doing this except adding the fields and making them serialize/deserialize correctly.
This is my first time contributing to the firebase .net sdk repo, so if you see anything dubious in the fork a bit later, when I've gotten it to works and such, do say something here, so that I can fix it before piling on a lot of work on a misguided version!
I created a pullrequest for this!
https://github.com/firebase/firebase-admin-dotnet/pull/409
If there is any deeper discussion to be had about it, that cannot be handled within the pr comments, I think that can be had here?
@lahirumaramba My pull request has been floating around for a while. If there is something wrong with it, i'm more than happy to keep working on it.