firebase-admin-dotnet icon indicating copy to clipboard operation
firebase-admin-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Use Invariant Culture when generating event_time

Open martinwiboe opened this issue 2 years ago • 3 comments

The current implementation uses the local culture to generate the event_time timestamp. If the local culture uses a non-US date format, the Firebase service will respond with an error code. This commit changes the implementation to always use the Invariant culture instead.

martinwiboe avatar Jul 06 '22 13:07 martinwiboe

I think this would fix my issue with this exception: FirebaseAdmin.Messaging.FirebaseMessagingException: Invalid value at 'message.android.notification.event_time' (type.googleapis.com/google.protobuf.Timestamp), Field 'event_time', Invalid time format: Failed to parse input

InspectlyMads avatar Aug 03 '22 10:08 InspectlyMads

@lahirumaramba sorry if it's not appropriate to tag you directly - but is there anything I need to do for this to be reviewed? The library is currently broken on non-US locales

martinwiboe avatar Aug 03 '22 21:08 martinwiboe

@lahirumaramba

Hello. I am also blocked by this issue. Is it possible to look at this issue ?

InspectlyMads has made a fork with the change as this has not been merged https://github.com/firebase/firebase-admin-dotnet/issues/330

larsbloch avatar Oct 12 '23 08:10 larsbloch