extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Update the SQL script used for generating latest snapshot II

Open dgilperez opened this issue 2 years ago • 3 comments

This is a follow up from #703 , rebasing against current next branch.

@dackers86 as discussed, this is my first PR to this repos, happy to follow any guidelines you have. I also did not manage to run the tests locally (if you can point me to env setup and instructions I'd appreciate)

dgilperez avatar Mar 14 '22 18:03 dgilperez

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Mar 14 '22 18:03 google-cla[bot]

Hello @dgilperez @dackers86

I have a collection that I've exported to BQ using the extension. The raw changelog table has 6.88 MB with ~1000 rows.

Currently querying is taking 47-90 seconds slot time to query the raw_latest view, which is huge for such a small table.

I'm not sure if I've messed up anything in the schema creation process, but was wondering whether this commit could help with that or if it's something deeper? Is there any ETA for this PR to be released?

tgpsantos avatar Mar 31 '22 17:03 tgpsantos

I ended up removing all views generated with this extension and recreated them using the code in this PR. That's working apparently fine in my end. You can try on new views with this code and check the results of both queries for consistency if you wish.

About the PR, it's unclear to me. It's my first contribution to the repo and I don't know how the process goes.

In my opinion, current released view queries are not usable, so I'd push this asap, but like I side we have our workaround.

El jue., 31 mar. 2022 19:15, tgpsantos @.***> escribió:

Hello @dgilperez https://github.com/dgilperez @dackers86 https://github.com/dackers86

I have a collection that I've exported to BQ using the extension. The raw changelog has 6.88 MB with ~1000 rows.

Currently querying is taking 47-90 seconds slot time to query the raw_latest view. I'm not sure if I've messed up anything in the schema creation process, but was wondering whether this commit could help with that or if it's something deeper? Is there any ETA for this PR to be released?

— Reply to this email directly, view it on GitHub https://github.com/firebase/extensions/pull/915#issuecomment-1084873491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACATDSWRWWLFSU5WLGXEK3VCXMUXANCNFSM5QWNVPYQ . You are receiving this because you were mentioned.Message ID: @.***>

dgilperez avatar Apr 02 '22 20:04 dgilperez