extensions icon indicating copy to clipboard operation
extensions copied to clipboard
verified publisher icon firebase

fix(firestore-send-email) restore headers support

Open Nushio opened this issue 6 months ago • 7 comments

I just noticed that this feature was removed, and wanted to contribute a quick fix.

Nushio avatar May 27 '25 22:05 Nushio

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 27 '25 22:05 google-cla[bot]

I've signed the CLA

Screenshot 2025-05-27 at 5 01 27 PM

Nushio avatar May 27 '25 23:05 Nushio

Hi, can you run npm run generate-readme in the firestore-send-email/functions directory

cabljac avatar May 30 '25 08:05 cabljac

I ran it but it removes the blurb I wrote about using Custom Headers.

Where should I place that instead? PREINSTALL.md ?

Edit: Done

Nushio avatar May 30 '25 13:05 Nushio

Any blockers on this PR?

Nushio avatar Jun 16 '25 15:06 Nushio

Hi! No blockers, just finding time to prioritise it. Sorry for the wait.

cabljac avatar Jun 17 '25 15:06 cabljac

Thanks, no problem. Just wondering if there was something else missing on my end.

Nushio avatar Jun 18 '25 20:06 Nushio

Thank you! I'll work on these tomorrow morning!

Nushio avatar Jul 04 '25 03:07 Nushio

@CorieW If I did things right, it should be mergeable now.

I used version 0.2.5 as it was the next number in the list.

Nushio avatar Jul 04 '25 18:07 Nushio

Hi! lgtm, i'll try and get this released this week.

cabljac avatar Jul 08 '25 15:07 cabljac

Closing to make some minor adjustments before release in https://github.com/firebase/extensions/pull/2463

Thank you for your PR!

CorieW avatar Jul 10 '25 11:07 CorieW

Super discouraging, but alright. :-/

Nushio avatar Jul 11 '25 17:07 Nushio

Apologies @Nushio, this was miscommunication on my part. I'll see what I can do about ensuring some attribution is recognised

cabljac avatar Jul 11 '25 19:07 cabljac

Hi @Nushio I've created a PR to correctly attribute you:

https://github.com/firebase/extensions/pull/2471

Apologies again, your contribution is very appreciated!

cabljac avatar Jul 11 '25 19:07 cabljac

Thank you!

Nushio avatar Jul 11 '25 19:07 Nushio

Sorry about this, @Nushio

I hope this experience doesn't discourage you. We really appreciate your contributions and want to support and encourage all contributors.

Once again, thank you for your work on this!

CorieW avatar Jul 11 '25 19:07 CorieW