extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Add strong types to some internal structs in firestore-bigquery-export

Open jmwski opened this issue 5 years ago • 5 comments

[READ] Step 1: Are you in the right place?

Issues filed here should be about a feature request for a specific extension in this repository. To file a feature request that affects multiple extensions or the Firebase Extensions platform, please reach out to Firebase support directly.

[REQUIRED] Step 2: Extension name

This an internal cleanup request is for extension: firestore-bigquery-export

What feature would you like to see?

There are a number of places where we pass around the any type. Specifically, we should have internal types for BigQuery schemas and Fields.

How would you use it?

N/A

jmwski avatar Feb 04 '20 18:02 jmwski

Hi, Jan, does that merged PR fix this?

karayu avatar May 04 '20 21:05 karayu

Hi, Jan, does that merged PR fix this?

I believe not. This PR is about adding typescript types to the extension code instead of using any/object types. It wouldn't change any interfaces. In my opinion, this is a lower-priority internal cleanup.

jmwski avatar May 05 '20 17:05 jmwski

Hi @IanWyszynski, is this a fix that you'd like to take on, or should we assign it to another maintainer to take a look?

jhuleatt avatar Nov 09 '20 23:11 jhuleatt

Hi @IanWyszynski, is this a fix that you'd like to take on, or should we assign it to another maintainer to take a look?

Hey, I'll take this and try to have a PR up this week.

jmwski avatar Nov 10 '20 00:11 jmwski

partially resolved in https://github.com/firebase/extensions/pull/2447

cabljac avatar Jul 02 '25 10:07 cabljac