extensions icon indicating copy to clipboard operation
extensions copied to clipboard

feat(storage-resize-images): update IMG_BUCKET param type to selectResource

Open yamankatby opened this issue 2 years ago • 1 comments

fixes: #1157

yamankatby avatar Aug 26 '22 12:08 yamankatby

LGTM! That's really all that's needed. The update flow will handle change of param type from string to selectResource.

pavelgj avatar Aug 26 '22 14:08 pavelgj

Can you please merge this?

pavelgj avatar Oct 25 '22 17:10 pavelgj

Hello @yamankatby & @pavelgj

I have some questions about this PR. I believe this has cause a non-backwards compatible change in the extension. Can you perhaps shed some light?

Previous to this version, I was able to specify any bucket in my GCP storage (v0.1.29). Now however, if I go to upgrade my extension, the "configure extension" section is actually forcing me to change the already configured bucket to the standard firebase appspot bucket (i.e. my-project-12345.appspot.com). Obviously, I can't do this because it will just break the configuration with my app... 😓

Is this an intentional side effect? Or am I just incredibly stupid and missing something obvious haha?

If this is indeed how it should be, I must say that this is very rough user experience and IMO should be reverted or fixed if possible.... 🤔

Would love to hear your thoughts! Thank you :)


Update:

Oh yeah, actually, nevermind. I just realized that I can import existing buckets into firebase. I will try that and that should work just fine! Sorry for the false alarm 🙏 Will update here if any issues arise

TangrisJones avatar Feb 03 '23 16:02 TangrisJones