codelab-friendlychat-ios icon indicating copy to clipboard operation
codelab-friendlychat-ios copied to clipboard

Firebase iOS Codelab Swift - Step 5 Error

Open dominiclancaster opened this issue 5 years ago • 2 comments

For https://codelabs.developers.google.com/codelabs/firebase-ios-swift/#4, under step 5 SignInViewController.swfit section, the following code

GIDSignIn.sharedInstance().uiDelegate = self GIDSignIn.sharedInstance().signInSilently()

should be

GIDSignIn.sharedInstance().presentingViewController = self GIDSignIn.sharedInstance().restorePreviousSignIn()

Reference: https://developers.google.com/identity/sign-in/ios/quick-migration-guide

dominiclancaster avatar Jan 28 '20 18:01 dominiclancaster

@kroikie can you take a look at this? I made some changes internally that are still pending, but we'll want both this and the objc codelab fully updated before May.

morganchen12 avatar Feb 14 '20 18:02 morganchen12

For the same step, shouldn't the Podfile also contain the following line?

pod 'GoogleSignIn'

Reference: https://firebase.google.com/docs/auth/ios/google-signin#before_you_begin

amrabed avatar Sep 10 '20 21:09 amrabed